feat Set all metrics related execution under prometheus feature flag

Author: fernandodeluret

crates/runtime/src/builder.rs

@@ -105,6 +105,7 @@ impl<K: BuilderKind, S: SourceTrait> Builder<K, S> {
         self
     }
 
+    #[cfg(feature = "prometheus")]
     /// Sets the metrics registry for the runtime.
     #[cfg(feature = "prometheus")]
     pub fn metrics(self, metrics_registry: prometheus::Registry) -> Builder<K, S> {

crates/runtime/src/lib.rs

@@ -12,9 +12,8 @@
 //! Vixen provides a simple API for requesting, parsing, and consuming data
 //! from Yellowstone.
 
-use std::marker::PhantomData;
-
 use config::BufferConfig;
+use std::marker::PhantomData;
 use tokio::sync::mpsc;
 use yellowstone_grpc_proto::tonic::Status;
 
@@ -31,6 +30,7 @@ pub mod builder;
 pub mod config;
 pub mod handler;
 pub mod instruction;
+
 pub mod sources;
 
 /// Utility functions for the Vixen runtime.

crates/runtime/src/metrics.rs

@@ -214,68 +214,30 @@ pub(crate) fn increment_received_updates(update_type: UpdateType) {
 }
 
 /// Register the metrics with the provided registry.
-/// # Panics
-/// If the metrics cannot be registered.
+/// This function is idempotent - if metrics are already registered, it will not panic.
 pub fn register_metrics(registry: &Registry) {
-    registry
-        .register(Box::new(VIXEN_TRANSACTIONS_RECEIVED.clone()))
-        .unwrap();
-    registry
-        .register(Box::new(VIXEN_TRANSACTIONS_SUCCESSFUL.clone()))
-        .unwrap();
-    registry
-        .register(Box::new(VIXEN_TRANSACTIONS_PARSING_ERRORS.clone()))
-        .unwrap();
-    registry
-        .register(Box::new(VIXEN_TRANSACTIONS_HANDLER_ERRORS.clone()))
-        .unwrap();
-
-    registry
-        .register(Box::new(VIXEN_ACCOUNTS_RECEIVED.clone()))
-        .unwrap();
-    registry
-        .register(Box::new(VIXEN_ACCOUNTS_SUCCESSFUL.clone()))
-        .unwrap();
-    registry
-        .register(Box::new(VIXEN_ACCOUNTS_PARSING_ERRORS.clone()))
-        .unwrap();
-    registry
-        .register(Box::new(VIXEN_ACCOUNTS_HANDLER_ERRORS.clone()))
-        .unwrap();
-
-    registry
-        .register(Box::new(VIXEN_BLOCK_METAS_RECEIVED.clone()))
-        .unwrap();
-    registry
-        .register(Box::new(VIXEN_BLOCK_METAS_SUCCESSFUL.clone()))
-        .unwrap();
-    registry
-        .register(Box::new(VIXEN_BLOCK_METAS_PARSING_ERRORS.clone()))
-        .unwrap();
-    registry
-        .register(Box::new(VIXEN_BLOCK_METAS_HANDLER_ERRORS.clone()))
-        .unwrap();
-
-    registry
-        .register(Box::new(VIXEN_INSTRUCTIONS_SUCCESSFUL.clone()))
-        .unwrap();
-    registry
-        .register(Box::new(VIXEN_INSTRUCTIONS_PARSING_ERRORS.clone()))
-        .unwrap();
-    registry
-        .register(Box::new(VIXEN_INSTRUCTIONS_HANDLER_ERRORS.clone()))
-        .unwrap();
-
-    registry
-        .register(Box::new(VIXEN_SLOTS_RECEIVED.clone()))
-        .unwrap();
-    registry
-        .register(Box::new(VIXEN_SLOTS_SUCCESSFUL.clone()))
-        .unwrap();
-    registry
-        .register(Box::new(VIXEN_SLOTS_PARSING_ERRORS.clone()))
-        .unwrap();
-    registry
-        .register(Box::new(VIXEN_SLOTS_HANDLER_ERRORS.clone()))
-        .unwrap();
+    // Try to register each metric, but ignore "AlreadyReg" errors
+    let _ = registry.register(Box::new(VIXEN_TRANSACTIONS_RECEIVED.clone()));
+    let _ = registry.register(Box::new(VIXEN_TRANSACTIONS_SUCCESSFUL.clone()));
+    let _ = registry.register(Box::new(VIXEN_TRANSACTIONS_PARSING_ERRORS.clone()));
+    let _ = registry.register(Box::new(VIXEN_TRANSACTIONS_HANDLER_ERRORS.clone()));
+
+    let _ = registry.register(Box::new(VIXEN_ACCOUNTS_RECEIVED.clone()));
+    let _ = registry.register(Box::new(VIXEN_ACCOUNTS_SUCCESSFUL.clone()));
+    let _ = registry.register(Box::new(VIXEN_ACCOUNTS_PARSING_ERRORS.clone()));
+    let _ = registry.register(Box::new(VIXEN_ACCOUNTS_HANDLER_ERRORS.clone()));
+
+    let _ = registry.register(Box::new(VIXEN_BLOCK_METAS_RECEIVED.clone()));
+    let _ = registry.register(Box::new(VIXEN_BLOCK_METAS_SUCCESSFUL.clone()));
+    let _ = registry.register(Box::new(VIXEN_BLOCK_METAS_PARSING_ERRORS.clone()));
+    let _ = registry.register(Box::new(VIXEN_BLOCK_METAS_HANDLER_ERRORS.clone()));
+
+    let _ = registry.register(Box::new(VIXEN_INSTRUCTIONS_SUCCESSFUL.clone()));
+    let _ = registry.register(Box::new(VIXEN_INSTRUCTIONS_PARSING_ERRORS.clone()));
+    let _ = registry.register(Box::new(VIXEN_INSTRUCTIONS_HANDLER_ERRORS.clone()));
+
+    let _ = registry.register(Box::new(VIXEN_SLOTS_RECEIVED.clone()));
+    let _ = registry.register(Box::new(VIXEN_SLOTS_SUCCESSFUL.clone()));
+    let _ = registry.register(Box::new(VIXEN_SLOTS_PARSING_ERRORS.clone()));
+    let _ = registry.register(Box::new(VIXEN_SLOTS_HANDLER_ERRORS.clone()));
 }