Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Duplicate Element Displayed and Warning Message 'Node with ID X Not Found' During Playback After Seeking Multiple Times. #1449

Open
1 task done
sandeshmurdia opened this issue Apr 16, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@sandeshmurdia
Copy link

sandeshmurdia commented Apr 16, 2024

Preflight Checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.

What package is this bug report for?

rrweb

Version

v2.0.0-alpha.7

Expected Behavior

  1. Within the createPlayerService function, there's a call to applyEventsSynchronously(syncEvents) in machine.ts during replay.
  2. When seeking consecutively twice on the same inactive region, syncEvents should be empty.
  3. If syncEvents contain any incremental snapshots, the system will attempt to apply the mutation again and attempt to remove node once more.
  4. At that point, if there are sync events, that particular node would not be found, leading to potential issues.

Actual Behavior

It is showing syncEvents if we are seeking twice in a same region and throwing up error Node id not found when we are trying to apply mutation on it.

Steps to Reproduce

To record:

  1. Create a session with a tab containing two sections. Each section should be toggleable by clicking on the tabs. Ensure the parent class remains same while the content should be different between the tabs. You can have any other element or something too but it would be easy in tabs
  2. Start recording and engage in activity on tab1 for 5-6 seconds. Then, switch to tab2 and here don't perform any actions/activity for 1min appx.
  3. Allow for a 1-minute period of inactivity to occur.
    The issue would be recorded

When replaying:

  1. Disable the skip inactivity feature.
  2. Upon watching the session, you should observe it playing correctly.
  3. However, when u will seek more than 2 times in the big inactive region(the 1 min inactivity which we had done in the session) and then again play the session by seeking it to start or before the tab switch.
  4. You may encounter a warning stating "Node with id x not found."
  5. and also you'll notice duplicate elements for the parent, resulting in the table being displayed twice when u will play the replay again.

Testcase Gist URL

No response

Additional Information

No response

@sandeshmurdia sandeshmurdia added the bug Something isn't working label Apr 16, 2024
@sandeshmurdia sandeshmurdia changed the title [Bug]: Duplicate Element Displayed and Warning Message 'Node with ID X Not Found' During Playback After Seeking Multiple Times [Bug]: Duplicate Element Displayed and Warning Message 'Node with ID X Not Found' During Playback After Seeking Multiple Times. Apr 16, 2024
@sandeshmurdia
Copy link
Author

image

Stack trace when the issue comes

@Kayrim
Copy link

Kayrim commented May 20, 2024

I experience similar issues:
image
Duplicates left in the recording.

Similar warning logs: console.js:273 [replayer] Node with id '964' not found.

@chetan-187
Copy link

image
@sandeshmurdia I also faced a similar issue. Let me know if you find any solution. My replayer is stuck on a particular point.

@vinodjoshi12
Copy link

vinodjoshi12 commented Jul 18, 2024

I also faced a similar issue

Screenshot 2024-07-18 at 6 56 00 PM Screenshot 2024-07-18 at 4 40 30 PM

@sandeshmurdia
Copy link
Author

I experience similar issues: image Duplicates left in the recording.

Similar warning logs: console.js:273 [replayer] Node with id '964' not found.

I got a hacky solution to it, in which you can stop passing the elements in this function (applyEventsSynchronously) if seeking in the inactive region

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants