-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature request]: Record/replay css animation's currentTime
#1491
Comments
You've found a tricky one @oceanMa1, to get this working we'd need to call Also we can listen for |
This is very much related to #1143 |
currentTime
Is the problem caused because the checkouteverynth approach creates a FullSnapshot event which causes an entire rebuild of the replayer state? |
I think you're correct. When I replay and filter out all the snapshots after the first one, this issue can be resolved. The code is as follows. @Juice10
|
I think that is exactly what is happening, entire rebuild is triggering the animation every time it's rebuilt.
That would also solve this issue in this instance I think. And it could really help for performance by eliminating repaints. |
We don't use
Yes; although you probably want a full refresh for a regular FullSnapshot (as probably calculating the diff would be more work than replacing and e.g you might actually want to do the full refresh to restart animations) Would using some of the other approaches instead of |
Preflight Checklist
What package is this bug report for?
rrweb
Version
2.0.0-alpha.13
Expected Behavior
When I use checkoutEveryNms: 2000 for recording, if the content being recorded contains animation, then every 2s this animation will be triggered repeatedly during playback. However, it works normally if checkoutEveryNms are not used.
Actual Behavior
When I use checkoutEveryNms: 2000 for recording, if the content being recorded contains animation, then every 2s this animation will be triggered repeatedly during playback. However, it works normally if checkoutEveryNms are not used.
Steps to Reproduce
Testcase Gist URL
https://rrwebdebug.com/play/index.html?url=https%3A%2F%2Fgist.github.com%2Fmhy17376555322%2F775375301a91079cc13a0e06dc44eafe&version=2.0.0-alpha.13&virtual-dom=on&play=on
Additional Information
No response
The text was updated successfully, but these errors were encountered: