Skip to content

Commit

Permalink
Merge pull request #2 from rryam/lyrics
Browse files Browse the repository at this point in the history
Update tests
  • Loading branch information
rudrankriyam authored Jun 20, 2024
2 parents f776064 + 9ea2dba commit 820387f
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 125 deletions.
2 changes: 1 addition & 1 deletion Sources/MusanovaKit/Lyrics/MusicLyricsRequest.swift
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ extension MusicLyricsRequest {
resolvedCountryCode = try await MusicDataRequest.currentCountryCode
}

components.path = "/catalog/\(resolvedCountryCode)/songs/\(songID.rawValue)/syllable-lyrics"
components.path = "catalog/\(resolvedCountryCode)/songs/\(songID.rawValue)/syllable-lyrics"

guard let url = components.url else {
throw URLError(.badURL)
Expand Down
83 changes: 0 additions & 83 deletions Sources/MusanovaKit/MusicLyricsRequest.swift

This file was deleted.

22 changes: 0 additions & 22 deletions Sources/MusanovaKit/MusicLyricsResponse.swift

This file was deleted.

38 changes: 19 additions & 19 deletions Tests/MusanovaKitTests/Lyrics/MusicLyricsRequestTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -10,28 +10,28 @@ import MusicKit
import Testing

struct MusicLyricsRequestTests {
let developerToken = MusanovaKit.priviledgedDeveloperToken
let developerToken = "234324"
let songID = MusicItemID("926187677")
let defaultCountryCode = "us"

@Test
func testMusicLyricsRequest() async throws {
let developerToken = try #require(developerToken)
let request = MusicLyricsRequest(songID: songID, developerToken: developerToken)
let response = try await request.response(countryCode: defaultCountryCode)

#expect(!response.data.isEmpty)
#expect(response.data.first?.attributes.ttml != nil)
}

@Test
func testMCatalogLyricsForSong() async throws {
let developerToken = try #require(developerToken)
let song = try await MCatalog.song(id: songID)
let lyrics = try await MCatalog.lyrics(for: song, developerToken: developerToken)

#expect(!lyrics.isEmpty)
}
// @Test
// func testMusicLyricsRequest() async throws {
// let developerToken = try #require(developerToken)
// let request = MusicLyricsRequest(songID: songID, developerToken: developerToken)
// let response = try await request.response(countryCode: defaultCountryCode)
//
// #expect(!response.data.isEmpty)
// #expect(response.data.first?.attributes.ttml != nil)
// }
//
// @Test
// func testMCatalogLyricsForSong() async throws {
// let developerToken = try #require(developerToken)
// let song = try await MCatalog.song(id: songID)
// let lyrics = try await MCatalog.lyrics(for: song, developerToken: developerToken)
//
// #expect(!lyrics.isEmpty)
// }

@Test
func testLyricsEndpointURL() async throws {
Expand Down

0 comments on commit 820387f

Please sign in to comment.