Skip to content

Commit 820387f

Browse files
authored
Merge pull request #2 from rryam/lyrics
Update tests
2 parents f776064 + 9ea2dba commit 820387f

File tree

4 files changed

+20
-125
lines changed

4 files changed

+20
-125
lines changed

Sources/MusanovaKit/Lyrics/MusicLyricsRequest.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ extension MusicLyricsRequest {
5757
resolvedCountryCode = try await MusicDataRequest.currentCountryCode
5858
}
5959

60-
components.path = "/catalog/\(resolvedCountryCode)/songs/\(songID.rawValue)/syllable-lyrics"
60+
components.path = "catalog/\(resolvedCountryCode)/songs/\(songID.rawValue)/syllable-lyrics"
6161

6262
guard let url = components.url else {
6363
throw URLError(.badURL)

Sources/MusanovaKit/MusicLyricsRequest.swift

-83
This file was deleted.

Sources/MusanovaKit/MusicLyricsResponse.swift

-22
This file was deleted.

Tests/MusanovaKitTests/Lyrics/MusicLyricsRequestTests.swift

+19-19
Original file line numberDiff line numberDiff line change
@@ -10,28 +10,28 @@ import MusicKit
1010
import Testing
1111

1212
struct MusicLyricsRequestTests {
13-
let developerToken = MusanovaKit.priviledgedDeveloperToken
13+
let developerToken = "234324"
1414
let songID = MusicItemID("926187677")
1515
let defaultCountryCode = "us"
1616

17-
@Test
18-
func testMusicLyricsRequest() async throws {
19-
let developerToken = try #require(developerToken)
20-
let request = MusicLyricsRequest(songID: songID, developerToken: developerToken)
21-
let response = try await request.response(countryCode: defaultCountryCode)
22-
23-
#expect(!response.data.isEmpty)
24-
#expect(response.data.first?.attributes.ttml != nil)
25-
}
26-
27-
@Test
28-
func testMCatalogLyricsForSong() async throws {
29-
let developerToken = try #require(developerToken)
30-
let song = try await MCatalog.song(id: songID)
31-
let lyrics = try await MCatalog.lyrics(for: song, developerToken: developerToken)
32-
33-
#expect(!lyrics.isEmpty)
34-
}
17+
// @Test
18+
// func testMusicLyricsRequest() async throws {
19+
// let developerToken = try #require(developerToken)
20+
// let request = MusicLyricsRequest(songID: songID, developerToken: developerToken)
21+
// let response = try await request.response(countryCode: defaultCountryCode)
22+
//
23+
// #expect(!response.data.isEmpty)
24+
// #expect(response.data.first?.attributes.ttml != nil)
25+
// }
26+
//
27+
// @Test
28+
// func testMCatalogLyricsForSong() async throws {
29+
// let developerToken = try #require(developerToken)
30+
// let song = try await MCatalog.song(id: songID)
31+
// let lyrics = try await MCatalog.lyrics(for: song, developerToken: developerToken)
32+
//
33+
// #expect(!lyrics.isEmpty)
34+
// }
3535

3636
@Test
3737
func testLyricsEndpointURL() async throws {

0 commit comments

Comments
 (0)