Committing fixes to Get-PublicIPAddress #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found that the tentacle agent doesn't need a port to register with the Octopus Server. Removed the TCPTest check and port parameter from the Get-IP function
Updated testing so if Server URL contains port number, it can be extracted and tested against. Otherwise the test just looks for a ping response.
Incremented version in psd1 to 2.20 and set powershell version to 4.0
When scraping the metadata on ec2 instances, I had to use the WebClient method to return the IP Address if the script runs as system. I also made it possible for the script to throw an error if the function failed to grab an IP Address. ReadMe has been updated accordingly.
leshkinski
pushed a commit
to leshkinski/OctopusDSC
that referenced
this pull request
Jan 12, 2016
…teractive Avoid powershell interactive mode errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix implemented to account for port number in Server URL when testing for a connection to Octopus Server.