Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serde support? #3

Open
matthiasbeyer opened this issue Apr 14, 2023 · 4 comments · Fixed by #5
Open

Serde support? #3

matthiasbeyer opened this issue Apr 14, 2023 · 4 comments · Fixed by #5
Milestone
2.0

Comments

@matthiasbeyer
Copy link

Hi!

I love this crate, really nice what it does! I think it would be appropriate to add serde support, right? Because users of this crate might want to use it to let their users configure stuff...

What do you think?
@matthiasbeyer matthiasbeyer mentioned this issue Apr 14, 2023
Open
@rsalmei
Copy link
Owner

rsalmei commented Apr 15, 2023

Hi, @matthiasbeyer!

Thanks, man!
Humm, interesting, I'd never thought about putting serde here, but sure! I can do it.
Would it be ok if it was behind a feature?

@matthiasbeyer
Copy link
Author

Hey! Thanks for considering it! Yes, behind a feature is totally fine (most crates do it like that)! ❤️

@matthiasbeyer matthiasbeyer mentioned this issue Apr 15, 2023
Open
@rsalmei rsalmei mentioned this issue Apr 19, 2023
Merged
@rsalmei
Copy link
Owner

rsalmei commented Apr 19, 2023

Sure, you're welcome!
It is released @matthiasbeyer! 😜

@rsalmei rsalmei reopened this Aug 27, 2024
@rsalmei
Copy link
Owner

rsalmei commented Aug 27, 2024

Reopening this, since the serde support is being reworked for the 2.0 version.

@rsalmei rsalmei added this to the 2.0 milestone Aug 28, 2024
@rsalmei rsalmei modified the milestone: 2.0 Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Include serde support rsalmei/human-repr
2 participants
@matthiasbeyer @rsalmei