Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to use SI and IEC together #7

Open
DDtKey opened this issue Jan 26, 2024 · 3 comments
Open

Ability to use SI and IEC together #7

DDtKey opened this issue Jan 26, 2024 · 3 comments
Labels
feature request New feature or request
Milestone

Comments

@DDtKey
Copy link

DDtKey commented Jan 26, 2024

Thanks for the library!

I’d like to be able to use both SI and IEC within the same crate, instead of changing the behavior with feature.

Probably just separate function names for iec?
It still can be under the feature to extend the trait

@rsalmei
Copy link
Owner

rsalmei commented Jan 29, 2024

Sure thing! 👍

Humm, really? I haven't anticipated anyone would like to use both together...

I can do it, but I'll have to think it through.
Well, the public API of human-repr are its three traits, so perhaps I could externalize all combinations within them, and have the simpler iconic methods be controlled by the features...

It should take a while, I'm afraid. I'm dealing with another ticket at the moment, and even other projects of mine, but I'll get to it eventually.

@rsalmei rsalmei added the feature request New feature or request label Jan 29, 2024
@DDtKey
Copy link
Author

DDtKey commented Jan 29, 2024

I haven't anticipated anyone would like to use both together...

I think it's not that weird, for example the output depends on some input params, so we can use either IEC or SI regardless of features, just by intention using conditions in runtime.

It should take a while,

Sure, take your time. Thanks for considering the idea

@rsalmei
Copy link
Owner

rsalmei commented Jan 29, 2024

Yep, you're right.
Sure, you're welcome!

@rsalmei rsalmei added this to the 2.0 milestone Aug 28, 2024
rsalmei added a commit that referenced this issue Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants