Cleanup. 3.2.0 preparation.

Author: andrewvk

Build/Props/CodeJam.Default.props

@@ -9,8 +9,8 @@
 		<DelaySign>False</DelaySign>
 		<AssemblyOriginatorKeyFile>..\Build\CodeJam.snk</AssemblyOriginatorKeyFile>
 
-		<Version>3.1.0.0</Version>
-		<PackageVersion>3.1.0</PackageVersion>
+		<Version>3.2.0.0</Version>
+		<PackageVersion>3.2.0</PackageVersion>
 		<PackageOutputPath>..\_Results</PackageOutputPath>
 
 		<Company>RSDN</Company>

CodeJam.Main/Assertions/ArgumentAssertion.cs

@@ -4,7 +4,7 @@
 	/// Builder type for argument assertions.
 	/// </summary>
 	/// <typeparam name="T">Type of the argument.</typeparam>
-	public struct ArgumentAssertion<T>
+	public readonly struct ArgumentAssertion<T>
 	{
 		/// <summary>
 		/// Initialize instance.

CodeJam.Main/Collections/ComparerBuilder.cs

@@ -3,6 +3,7 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Linq.Expressions;
+// ReSharper disable once RedundantUsingDirective
 using System.Reflection;
 
 using JetBrains.Annotations;

CodeJam.Main/Collections/Enumerable/EnumerableExtensions.MinMaxBy.cs

@@ -68,8 +68,7 @@ public static TSource MinBy<TSource, TValue>(
 			Code.NotNull(source, nameof(source));
 			Code.NotNull(selector, nameof(selector));
 
-			if (comparer == null)
-				comparer = Comparer<TValue>.Default;
+			comparer ??= Comparer<TValue>.Default;
 
 			var value = default(TValue);
 			TSource item;
@@ -141,8 +140,7 @@ public static TSource MinByOrDefault<TSource, TValue>(
 			Code.NotNull(source, nameof(source));
 			Code.NotNull(selector, nameof(selector));
 
-			if (comparer == null)
-				comparer = Comparer<TValue>.Default;
+			comparer ??= Comparer<TValue>.Default;
 
 			var value = default(TValue);
 			TSource item;
@@ -245,8 +243,7 @@ public static TSource MaxBy<TSource, TValue>(
 			Code.NotNull(source, nameof(source));
 			Code.NotNull(selector, nameof(selector));
 
-			if (comparer == null)
-				comparer = Comparer<TValue>.Default;
+			comparer ??= Comparer<TValue>.Default;
 
 			var value = default(TValue);
 			TSource item;
@@ -318,8 +315,7 @@ public static TSource MaxByOrDefault<TSource, TValue>(
 			Code.NotNull(source, nameof(source));
 			Code.NotNull(selector, nameof(selector));
 
-			if (comparer == null)
-				comparer = Comparer<TValue>.Default;
+			comparer ??= Comparer<TValue>.Default;
 
 			var value = default(TValue);
 			TSource item;

CodeJam.Main/Configuration.cs

@@ -3,6 +3,7 @@
 using System.Diagnostics;
 using System.IO;
 using System.Threading;
+// ReSharper disable once RedundantUsingDirective
 using System.Threading.Tasks;
 
 using CodeJam.Threading;

CodeJam.Main/DisposableExtensions.cs

@@ -29,9 +29,7 @@ public static void DisposeAll([NotNull, ItemNotNull, InstantHandle] this IEnumer
 				}
 				catch (Exception ex)
 				{
-					if (exceptions == null)
-						exceptions = new List<Exception>();
-
+					exceptions ??= new List<Exception>();
 					exceptions.Add(ex);
 				}
 			}

CodeJam.Main/IO/TempData.cs

@@ -218,11 +218,9 @@ protected override void DisposePath([NotNull] string path, bool disposing)
 		[NotNull]
 		public static TempDirectory CreateDirectory([CanBeNull] string dirPath, [CanBeNull] string directoryName)
 		{
-			if (dirPath == null)
-				dirPath = Path.GetTempPath();
+			dirPath ??= Path.GetTempPath();
 
-			if (directoryName == null)
-				directoryName = GetTempName();
+			directoryName ??= GetTempName();
 
 			var directoryPath = Path.Combine(dirPath, directoryName);
 			var result = new TempDirectory(directoryPath);
@@ -247,11 +245,9 @@ public static TempDirectory CreateDirectory([CanBeNull] string dirPath, [CanBeNu
 		[NotNull]
 		public static TempFile CreateFile([CanBeNull] string dirPath, [CanBeNull] string fileName)
 		{
-			if (dirPath == null)
-				dirPath = Path.GetTempPath();
+			dirPath ??= Path.GetTempPath();
 
-			if (fileName == null)
-				fileName = GetTempName();
+			fileName ??= GetTempName();
 
 			var filePath = Path.Combine(dirPath, fileName);
 			var result = new TempFile(filePath);
@@ -288,11 +284,9 @@ public static FileStream CreateFileStream(
 		{
 			const int bufferSize = 4096;
 
-			if (dirPath == null)
-				dirPath = Path.GetTempPath();
+			dirPath ??= Path.GetTempPath();
 
-			if (fileName == null)
-				fileName = GetTempName();
+			fileName ??= GetTempName();
 
 			var filePath = Path.Combine(dirPath, fileName);
 

CodeJam.Main/Readme.txt

@@ -1,5 +1,15 @@
 CodeJam 3.1.0 Release Notes
--------------------------------
+---------------------------
+
+What's new in 3.2.0
+-------------------
+* CreateSingle performance improvements
+* Additional Stream helper methods
+* Configuration API and retry policy for temporary data helpers
+* ToCompositeRangeExclusive method
+* StringBuilder IsNullOrEmpty/NotNullNorEmpty methods
+* ForEachAsync method
+* Refactoring, fixes and and code cleanup
 
 What's new in 3.1.0
 -------------------

CodeJam.Main/Reflection/AssemblyExtensions.cs

@@ -24,7 +24,7 @@ public static class AssemblyExtensions
 		public static bool IsDebugAssembly([NotNull] this Assembly assembly)
 		{
 			Code.NotNull(assembly, nameof(assembly));
-			return assembly.GetCustomAttribute<System.Diagnostics.DebuggableAttribute>()?.IsJITOptimizerDisabled ?? false;
+			return assembly.GetCustomAttribute<DebuggableAttribute>()?.IsJITOptimizerDisabled ?? false;
 		}
 #endif
 

CodeJam.Main/Structures/Option/Option`1.cs

@@ -93,10 +93,9 @@ public bool Equals(Option<T> other)
 			if (other == null)
 				return false;
 
-			var thisSome  = this as Some;
 			var otherSome = other as Some;
 
-			if (ReferenceEquals(thisSome, null))
+			if (!(this is Some))
 				return ReferenceEquals(otherSome, null);
 
 			if (ReferenceEquals(otherSome, null))