Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Convert all layouts to simple layouts #140

Open
rsheldiii opened this issue Feb 20, 2022 · 0 comments
Open

Enhancement: Convert all layouts to simple layouts #140

rsheldiii opened this issue Feb 20, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@rsheldiii
Copy link
Owner

The layout function signature is a little meaty:

module layout(list, profile="dcs", legends=undef, front_legends=undef, row_sculpting_offset=0, row_override=undef, column_sculpt_profile="2hands", column_override=undef)

that's the definition of a code smell if I've ever seen one. In an attempt to localize the logic around layouts i've over-localized, and require all layout logic to flow through the layout function.

simple_layout still contains some magic, but not nearly as much. It sets the length of the key, $row and $column, and the position and expects the child to do the rest. This will make the layout function much more extensible at the cost of a steeper learning curve.

@rsheldiii rsheldiii added the enhancement New feature or request label Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant