Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanly Cloned Version 2.4.0 is not working correctly. #194

Open
Sebastian-Lamay opened this issue Aug 10, 2023 · 2 comments
Open

Cleanly Cloned Version 2.4.0 is not working correctly. #194

Sebastian-Lamay opened this issue Aug 10, 2023 · 2 comments

Comments

@Sebastian-Lamay
Copy link

Sebastian-Lamay commented Aug 10, 2023

What version of OpenSCAD are you on?
OpenSCAD version 2021.01
Cloned the Master Branch so 2.4.0

Describe the bug
When running any of the examples in keys.scad there are Warnings on the console, Keys don't generate correctly.

Error Log shows:
WARNING: Can't call function on dynamically scoped variable in file functions.scad, line 29
WARNING: undefined operation (number + undefined) in file functions.scad, line 29
WARNING: undefined operation (undefined * number) in file key.scad, line 53
WARNING: Unable to convert cube(size=[18.24, undef, 0.01], ...) parameter to a number or a vec3 of numbers in file src/key.scad, line 53

To Reproduce
Steps to reproduce the behavior:

  1. Clone Master Branch
  2. Open Keys.scad
  3. See error

Additional context
Version 2.3.0 seems to work fine on my machine. I'm running on PopOs

@Riesi
Copy link

Riesi commented Aug 10, 2023

I am also hitting this.
The issue seems to be in file functions.scad at line 30

function key_height_at_progress(progress = 0) = $bottom_key_height + ($unit * ($key_height - 1)) - $height_difference + $side_sculpting(progress);

The function $side_sculpting(progress) is not implemented in this file as mentioned in the TODO above.

If I remove it the default key cap is generated fine.

function key_height_at_progress(progress = 0) = $bottom_key_height + ($unit * ($key_height - 1)) - $height_difference;

But I cant generate different keys after fixing the warnings still...

@Gitznik
Copy link

Gitznik commented Oct 6, 2023

I fixed this by running KeyV2 through the latest AppImage developer snapshot of OpenSCAD (2023.09.30.ai16393 (git f41aefc37)).

Hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants