CI updates

- Re order npm scripts and reduce them to the actual needs
- Configure sonar to evaluate code coverage
- Configure sonar cloud status badge

Author: josedahlquist

.github/workflows/build.yml

@@ -24,17 +24,9 @@ jobs:
           npm ci
           npm run unit-test
           npm run eslint
-          npm run only-cobertura
-
-      - name: Code Coverage Report
-        uses: irongut/[email protected]
-        with:
-          filename: coverage/cobertura-coverage.xml
-          badge: true
-          fail_below_min: true
-          format: markdown
-          hide_branch_rate: false
-          hide_complexity: true
-          indicators: true
-          output: console
-          thresholds: '70 90'
+          npm run only-coverage
+      - name: SonarCloud Scan
+        uses: SonarSource/sonarcloud-github-action@master
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          SONAR_TOKEN: ${{ secrets.SONARCLOUD_TOKEN }}

.github/workflows/code-coverage-results.md

@@ -71,7 +71,6 @@ typings/
 data/*
 # sessionDB local
 SessionDB/data/redis-data
-sonar-project.properties
 .scannerwork
 
 # rsk db data

.gitignore

@@ -1,3 +1,5 @@
+[![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=rsksmart_2wp-api&metric=alert_status)](https://sonarcloud.io/summary/new_code?id=rsksmart_2wp-api)
+
 # 2wp-api
 
 This is the API component for 2-Way-Peg solution.

README.md

@@ -12,34 +12,40 @@
     "node": ">=10.16"
   },
   "scripts": {
+    "clean": "lb-clean dist *.tsbuildinfo .eslintcache",
+
     "build": "lb-tsc",
     "build:watch": "lb-tsc --watch",
+    "rebuild": "npm run clean && npm run build",
+
     "lint": "npm run eslint",
-    "coverage": "npm run pretest && lb-nyc mocha --recursive 'dist/__tests__/**/*.unit.js' --timeout 10000 && lb-nyc report --reporter=cobertura",
-    "only-cobertura": "lb-nyc report --reporter=cobertura",
-    "coverage:ci": "lb-nyc report --reporter=cobertura | coveralls",
     "lint:fix": "npm run eslint:fix && npm run prettier:fix",
+    "eslint": "lb-eslint --report-unused-disable-directives .",
+    "eslint:fix": "npm run eslint -- --fix",
     "prettier:cli": "lb-prettier \"**/*.ts\" \"**/*.js\"",
     "prettier:check": "npm run prettier:cli -- -l",
     "prettier:fix": "npm run prettier:cli -- --write",
-    "eslint": "lb-eslint --report-unused-disable-directives .",
-    "eslint:fix": "npm run eslint -- --fix",
-    "unit-test": "npm run pretest && lb-nyc mocha --recursive 'dist/__tests__/**/*.unit.js' --timeout 10000",
-    "pretest": "npm run clean && npm run build",
+
+    "precoverage": "npm run unit-test",
+    "coverage": "lb-nyc report --reporter=text --reporter=lcov",
+    "only-coverage": "lb-nyc report --reporter=lcov",
+
+    "pretest": "npm run rebuild",
     "test": "lb-nyc mocha --recursive 'dist/__tests__/**/*.js' --timeout 10000",
     "posttest": "npm run lint",
     "test:dev": "lb-nyc mocha --allow-console-logs dist/__tests__/**/*.js && npm run posttest",
-    "precoverage": "npm test",
-    "premigrate": "npm run build",
+    "unit-test": "npm run pretest && lb-nyc mocha --recursive 'dist/__tests__/**/*.unit.js' --timeout 10000",
+
+    "premigrate": "npm run rebuild",
     "migrate": "node ./dist/migrate",
-    "preopenapi-spec": "npm run build",
+
+    "preopenapi-spec": "npm run rebuild",
     "openapi-spec": "node ./dist/openapi-spec",
-    "rebuild": "npm run clean && npm run build",
+
     "prestart": "npm run rebuild",
     "start": "node -r source-map-support/register .",
-    "start-daemon": "npm run prestart && node -r source-map-support/register . --appmode=DAEMON",
-    "start-api": "npm run prestart && node -r source-map-support/register . --appmode=API",
-    "clean": "lb-clean dist *.tsbuildinfo .eslintcache"
+    "start-api": "npm run start -- --appmode=API",
+    "start-daemon": "npm run start -- --appmode=DAEMON"
   },
   "repository": {
     "type": "git",

package.json

@@ -0,0 +1,3 @@
+sonar.projectKey=rsksmart_2wp-api
+sonar.organization=rsksmart
+sonar.javascript.lcov.reportPaths=./coverage/lcov.info