Check for nil resp before using resp.Status after DialContext error (#109)

ronakg · web-flow · commit 517c66e6d46d · 2021-04-26T12:20:33.000+08:00
* Includes HTTP error code when gorilla DialContext fails

* Check for nil resp before using resp.Status
diff --git a/core/transport/websocket_transport.go b/core/transport/websocket_transport.go
@@ -186,7 +186,11 @@ func NewWebsocketClientTransport(ctx context.Context, url string, config *tls.Co
 	}
 	conn, resp, err := dial.DialContext(ctx, url, header)
 	if err != nil {
-		return nil, errors.Wrapf(err, "dial websocket failed: %s", resp.Status)
+		if resp != nil {
+			return nil, errors.Wrapf(err, "dial websocket failed: %s", resp.Status)
+		} else {
+			return nil, errors.Wrap(err, "dial websocket failed")
+		}
 	}
 	return NewTransport(NewWebsocketConnection(conn)), nil
 }

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,11 @@ func NewWebsocketClientTransport(ctx context.Context, url string, config *tls.Co`
`186`	`186`	`}`
`187`	`187`	`conn, resp, err := dial.DialContext(ctx, url, header)`
`188`	`188`	`if err != nil {`
`189`		`- return nil, errors.Wrapf(err, "dial websocket failed: %s", resp.Status)`
	`189`	`+ if resp != nil {`
	`190`	`+ return nil, errors.Wrapf(err, "dial websocket failed: %s", resp.Status)`
	`191`	`+ } else {`
	`192`	`+ return nil, errors.Wrap(err, "dial websocket failed")`
	`193`	`+ }`
`190`	`194`	`}`
`191`	`195`	`return NewTransport(NewWebsocketConnection(conn)), nil`
`192`	`196`	`}`