Skip to content

Conversation

@viglucci
Copy link
Member

@viglucci viglucci commented Jul 4, 2025

Updates the browser-bundle webpack example to show the generation of two "libraries" which is more representation of a real world scenario. Additionally updates dependency versions to adress dependabot alerts.

Motivation:

Example matches real-world scenario better + adress dependabot alerts.

Modifications:

  • Bumped ws & webpack dependency versions in webpack examples
  • Updated webpack/browser-bundle example to produce two "libraries" and re-arrange source scripts

Result:

n/a

@viglucci viglucci requested a review from Copilot July 4, 2025 03:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the webpack examples by bumping Node and key dependency versions, improves error handling in the simple client, and restructures the browser-bundle setup to output two libraries with updated source layout.

  • Bump Node engine and major deps (ws, webpack, webpack-cli, webpack-dev-server) across examples
  • Enhance simple client with try/catch on connection failures
  • Refactor browser-bundle: split entry into rsocket and app, move assets into src/, update HTML and README paths

Reviewed Changes

Copilot reviewed 10 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/rsocket-examples/src/webpack/simple/server/package.json Bumped Node engine to ^18; updated ws to ^8.18
packages/rsocket-examples/src/webpack/simple/client/package.json Bumped Node engine to ^18; updated webpack deps to major ^5
packages/rsocket-examples/src/webpack/simple/client/index.js Wrapped connector.connect() in try/catch to show UI error
packages/rsocket-examples/src/webpack/browser-bundle/webpack.config.js Split entry into two libraries (rsocket, app); updated output and HTML plugin paths/inject
packages/rsocket-examples/src/webpack/browser-bundle/src/index.html Added base HTML under src/
packages/rsocket-examples/src/webpack/browser-bundle/src/app.js New example app script handling send/connect UI
packages/rsocket-examples/src/webpack/browser-bundle/package.json Bumped Node engine to ^18; updated webpack deps to major ^5
packages/rsocket-examples/src/webpack/browser-bundle/README.md Updated paths and corrected typos
packages/rsocket-examples/package.json Updated ws dependency to ^8.18
Comments suppressed due to low confidence (2)

packages/rsocket-examples/src/webpack/browser-bundle/webpack.config.js:18

  • The comment refers to 'library' but the entry names are 'rsocket' and 'app'. Consider updating it to "[name] will be replaced by 'rsocket' or 'app'" for accuracy.
    filename: "[name].js", // [name] will be replaced by 'app' or 'library'

packages/rsocket-examples/src/webpack/browser-bundle/src/app.js:3

  • [nitpick] The name _rsocket is similar to the global rsocket library export. Consider renaming it (e.g., client, socketClient) to avoid confusion.
var _rsocket = null;

Signed-off-by: Kevin Viglucci <[email protected]>
@viglucci viglucci force-pushed the chore/example-dependency-versions branch from 353a89a to f61f8b1 Compare July 4, 2025 03:18
@viglucci viglucci merged commit 6cda0de into 1.0.x-alpha Jul 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants