Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_quillt_pkgdown() should add the vignette infrastructure too #37

Open
cderv opened this issue Jul 19, 2021 · 0 comments
Open

use_quillt_pkgdown() should add the vignette infrastructure too #37

cderv opened this issue Jul 19, 2021 · 0 comments
Assignees

Comments

@cderv
Copy link
Collaborator

cderv commented Jul 19, 2021

I think from rstudio/rticles#412 as some files were missing (rstudio/rticles@8f81237) that use_quillt_pkgdown() is not complete.

As we are creating the vignette from a template

quillt/R/templates.R

Lines 93 to 97 in f6c6729

# Add vignette used as Get Started.
usethis::ui_info("Adding package named vignette for Get Started section.")
use_template("vignette-intro.Rmd",
intro_rmd <- file.path("vignettes", paste0(data$Package, ".Rmd")),
data = data, ignore = FALSE, open = FALSE)

we don't use usethis::use_vignette(), which leads to missing part in the package when no vignettes are already there.

This should be improved.

@cderv cderv self-assigned this Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant