Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment introspection failures are not handled #144

Closed
mmarchetti opened this issue Dec 28, 2018 · 2 comments
Closed

Environment introspection failures are not handled #144

mmarchetti opened this issue Dec 28, 2018 · 2 comments
Labels

Comments

@mmarchetti
Copy link
Contributor

If introspection of the python environment fails, a JSON object with an error field is returned. The front end should report that error and stop the deployment. Instead, it passes the (invalid) environment description to the backend which fails with this error:

[E 14:52:45.406 NotebookApp] Bundle creation failed
    Traceback (most recent call last):
      File "/rsconnect_jupyter/rsconnect_jupyter/__init__.py", line 117, in post
        bundle = make_source_bundle(model, environment, ext_resources_dir, extra_files=[])
      File "/rsconnect_jupyter/rsconnect_jupyter/bundle.py", line 117, in make_source_bundle
        manifest = make_source_manifest(nb_name, environment, 'jupyter-static')
      File "/rsconnect_jupyter/rsconnect_jupyter/bundle.py", line 20, in make_source_manifest
        package_manager = environment['package_manager']
    KeyError: 'package_manager'
@mmarchetti
Copy link
Contributor Author

The front end error field shows Bundle creation failed: 'package_manager'

@joncfoo
Copy link
Contributor

joncfoo commented Jan 24, 2019

Closing in favor of #155

@joncfoo joncfoo closed this as completed Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants