Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA release process should be more idempotent #317

Open
scottmmjackson opened this issue Nov 18, 2021 · 2 comments
Open

GHA release process should be more idempotent #317

scottmmjackson opened this issue Nov 18, 2021 · 2 comments

Comments

@scottmmjackson
Copy link
Contributor

Had to update some credentials to make the release process work right and the entire workflow failed because a github release already existed.

We should trap for this case and either replace or skip that step.

Not sure if there's anything else we need to do to rerun half-finished releases but it's worth checking it out.

@scottmmjackson
Copy link
Contributor Author

Looks like we also fail the distributions step when we try to upload an existing package to pypi

@scottmmjackson
Copy link
Contributor Author

So being a little more clear- once we do the pypi upload there's no backing out. So maybe what we need is:

  • Make PyPI step the last one, and add every other step as a dependency
  • Make github release call idempotent either by trapping for existing release or always deleting and reuploading (the latter feels wrong)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant