Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate if we still need to pin virtualenv<20 #715

Open
ianpittwood opened this issue Apr 1, 2024 · 2 comments
Open

Evaluate if we still need to pin virtualenv<20 #715

ianpittwood opened this issue Apr 1, 2024 · 2 comments
Labels
dependencies Updates to dependency files product-base Related to the product base images tech debt Technical debt we should address

Comments

@ianpittwood
Copy link
Collaborator

I noticed that we use virtualenv<20 in our base image without further context. I suspect this was put in due to an older issue with Debian-based OSes like this: python/mypy#10407

We should evaluate whether we can remove this line and move forward with using modern versions of virtualenv in our base image.

@ianpittwood ianpittwood added dependencies Updates to dependency files tech debt Technical debt we should address product-base Related to the product base images labels Apr 1, 2024
@aronatkins
Copy link
Contributor

The virtualenv<20 constraint was introduced because early versions had some problems. Internally, we removed some of those constraints around the time of 20.0.20. CC @mmarchetti for more context.

@mmarchetti
Copy link
Contributor

Virtualenv 20 was a rewrite, which naturally introduced many breaking changes and bugs.

The original issue was https://github.com/rstudio/connect/issues/16474. After working around that on the Connect side, we encountered an issue with how environments are built: https://github.com/rstudio/connect/issues/16569. We documented a requirement for virtualenv<20 and configured all of our docker images and test environments that way. A few months later, once virtualenv had stabilized, we removed the constraint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates to dependency files product-base Related to the product base images tech debt Technical debt we should address
Projects
None yet
Development

No branches or pull requests

3 participants