-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The return value of bootstrapPage() has changed in an unfortunate way #3235
Comments
…b isn't relevant Also, improved error message if theme is a character vector with 2 or more elements
Question: Does this mean that if bslib is used, |
No, but it does means that the way in which you're using |
…ant (#3236) * Close #3235: Don't change the return value of bootstrapPage() if bslib isn't relevant Also, improved error message if theme is a character vector with 2 or more elements * yarn build (GitHub Actions) * bump version * yarn build (GitHub Actions) * Don't add an additional level to the returned tree structure * More straightforward use of do.call() Co-authored-by: cpsievert <[email protected]> Co-authored-by: Winston Chang <[email protected]>
Ah. So I could check the |
With the current CRAN version of shiny (1.5.0):
With the development version (> 1.5.0):
This means, user code that does something like this will now break:
We can do better to not break this code if
{bslib}
isn't being used, but the structure will likely have to change if{bslib}
is being used.Some relevant discussion/use-case radiant-rstats/radiant.data#26 (comment)
The text was updated successfully, but these errors were encountered: