From 7509a52f88708eab85dc42cc1ed1dfd05dc43c72 Mon Sep 17 00:00:00 2001
From: Barret Schloerke <barret@posit.co>
Date: Tue, 12 Mar 2024 16:38:07 -0400
Subject: [PATCH] checks

---
 .Rbuildignore        | 1 +
 R/test-in-local.R    | 2 +-
 R/view-test-images.R | 2 ++
 man/test_in_local.Rd | 2 +-
 4 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/.Rbuildignore b/.Rbuildignore
index 5e8ac7cb1f..3f86e672e7 100644
--- a/.Rbuildignore
+++ b/.Rbuildignore
@@ -11,6 +11,7 @@
 ^todo\.md$
 
 ^inst/apps/.*/tests/.*
+^inst/apps/\.renvignore$
 \.jshintrc$
 www/nvd3/deprecated
 ^_pkgdown\.yml$
diff --git a/R/test-in-local.R b/R/test-in-local.R
index c003421811..e70a8ae405 100644
--- a/R/test-in-local.R
+++ b/R/test-in-local.R
@@ -14,7 +14,7 @@ ci_status <- list(
 #' @param retries number of attempts to retry before declaring the test a failure
 #' @param repo_dir Location of local shinycoreci repo
 #' @param ... ignored
-#' @param install If \code{TRUE}, installs shinyverse in the default libpath before running tests. App dependencies will always be installed if missing.
+#' @param local_pkgs If `TRUE`, the local `.libPaths()[1]` will be used. If `FALSE`, a persistent shinycoreci libpath will be used. Only when `local_pkgs=FALSE` will app dependencies be installed.
 #' @export
 test_in_local <- function(
     apps = apps_with_tests(repo_dir),
diff --git a/R/view-test-images.R b/R/view-test-images.R
index 348ead28f1..0bcf2f7e14 100644
--- a/R/view-test-images.R
+++ b/R/view-test-images.R
@@ -1,3 +1,5 @@
+utils::globalVariables(c("png_name", "test_name", "variant"))
+
 #' View Shinytest Images
 #'
 #' @param repo_dir directory to the shinycoreci repo
diff --git a/man/test_in_local.Rd b/man/test_in_local.Rd
index ff9a184d57..9d4f77b1be 100644
--- a/man/test_in_local.Rd
+++ b/man/test_in_local.Rd
@@ -27,7 +27,7 @@ test_in_local(
 
 \item{repo_dir}{Location of local shinycoreci repo}
 
-\item{install}{If \code{TRUE}, installs shinyverse in the default libpath before running tests. App dependencies will always be installed if missing.}
+\item{local_pkgs}{If \code{TRUE}, the local \code{.libPaths()[1]} will be used. If \code{FALSE}, a persistent shinycoreci libpath will be used. Only when \code{local_pkgs=FALSE} will app dependencies be installed.}
 }
 \description{
 Test apps using \code{shiny::runTests()} using local libpath