You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After PDEP-6, assigning values incompatible with the current dtype will require explicit an type conversion.
This will break inplace translation, since Series.astype returns a new object. It (should?) keep working for DataFrame, as in that case we simply replace the entire column.
Possible solution
Detect if pandas.Series is compatible with strings. If not, raise NotInplaceTranslatableError if inplace=True.
Description
After PDEP-6, assigning values incompatible with the current dtype will require explicit an type conversion.
This will break inplace translation, since
Series.astype
returns a new object. It (should?) keep working forDataFrame
, as in that case we simply replace the entire column.Possible solution
Detect if
pandas.Series
is compatible with strings. If not, raiseNotInplaceTranslatableError
ifinplace=True
.The exact exception type that will be raised is not known yet.
The text was updated successfully, but these errors were encountered: