hui:link-possible-types - Fix CI/CD build error

Also, remove debugging 'message' call.
hui--ibut-link-directly-to-dired - Handle non-readable input
  such as <ilink:...>.

Author: rswgnu

ChangeLog

@@ -1,3 +1,13 @@
+2023-11-06  Bob Weiner  <[email protected]>
+
+* hui.el (hui:link-possible-types): Fix CI/CD build error where
+    ilink was inserted when pathname was expected due to batch
+    diff when referent is in dired-mode.  Fix to skip button type
+    clauses it this case.
+  test/hui-tests.el (hui--ibut-link-directly-to-dired): Check that
+    looking at a string before trying to (read (current-buffer));
+    otherwise, 'read' will fail.
+
 2023-11-05  Bob Weiner  <[email protected]>
 
 * test/hyrolo-tests.el (hyrolo-demo-show-overview): Fix by adding

hui.el

@@ -3,7 +3,7 @@
 ;; Author:       Bob Weiner
 ;;
 ;; Orig-Date:    19-Sep-91 at 21:42:03
-;; Last-Mod:      6-Nov-23 at 19:16:42 by Bob Weiner
+;; Last-Mod:      6-Nov-23 at 19:36:33 by Bob Weiner
 ;;
 ;; SPDX-License-Identifier: GPL-3.0-or-later
 ;;
@@ -1852,7 +1852,8 @@ Buffer without File      link-to-buffer-tmp"
 
 			     ;; Next clause forces use of any ibut name in the link
 			     ;; and sets hbut:current button attributes.
-			     (t (cond ((and (prog1 (setq hbut-sym (hbut:at-p))
+			     (t (cond ((and (not (derived-mode-p 'dired-mode))
+					    (prog1 (setq hbut-sym (hbut:at-p))
 					      (save-excursion (ibut:at-to-name-p hbut-sym)))
 					    (setq lbl-key (hattr:get hbut-sym 'lbl-key))
 					    (eq (current-buffer) (get-file-buffer (gbut:file))))
@@ -1861,7 +1862,7 @@ Buffer without File      link-to-buffer-tmp"
 				       (list 'link-to-ebut lbl-key))
 				      ((and hbut-sym lbl-key)
 				       ;; On an implicit button, so link to it
-				       (message "%S" (hattr:list hbut-sym))
+				       ;; (message "%S" (hattr:list hbut-sym))
 				       (list 'link-to-ibut lbl-key (or buffer-file-name (buffer-name))))
 				      ((and (require 'bookmark)
 					    (derived-mode-p 'bookmark-bmenu-mode)

test/hui-tests.el

@@ -3,7 +3,7 @@
 ;; Author:       Mats Lidell <[email protected]>
 ;;
 ;; Orig-Date:    30-Jan-21 at 12:00:00
-;; Last-Mod:      5-Nov-23 at 17:16:45 by Bob Weiner
+;; Last-Mod:      6-Nov-23 at 19:39:45 by Bob Weiner
 ;;
 ;; SPDX-License-Identifier: GPL-3.0-or-later
 ;;
@@ -806,7 +806,8 @@ With point on label suggest that ibut for rename."
 	  ;; Implicit link should be the `dir' dired directory,
 	  ;; possibly minus the final directory '/'.
 	  (goto-char (point-min))
-          (should (string-prefix-p (read (current-buffer)) dir)))
+          (should (and (looking-at "\"")
+		       (string-prefix-p (read (current-buffer)) dir))))
       (hy-delete-file-and-buffer file))))
 
 (ert-deftest hui--ibut-link-directly-with-label ()