Removed {C-c C-r} ebut:rename binding due to major-mode conflicts

Author: rswgnu

Changes

@@ -1,5 +1,11 @@
 2020-02-16  Bob Weiner  <[email protected]>
 
+* man/hyperbole.texi (Renaming, Global Key Bindings):
+  hyperbole.el (hkey-initialize):
+  hui-mini.el (hui:menus):
+  hui-menu.el (hui-menu-key-bindings): Removed {C-c C-r} ebut rename binding since conflicts with bindings
+    commonly made in some modes.  Use menu instead or choose a personal binding.
+
 * hui.el (hui:hbut-help): Improved to flash unnamed implicit buttons with lbl-start and lbl-end properties.
 
 * hyperbole.el (hyperb:autoloads-exist-p, hyperb:maybe-generate-autoloads, hyperb:generate-autoloads):

HY-NEWS

@@ -41,6 +41,11 @@
     - Much improved conversion of MSWindows UNC paths to existing Posix mount
       points when running Emacs under Windows Subsystem for Linux.
 
+  KEYS
+
+    - Removed {C-c C-r} key binding for explicit button renaming due to
+      conflicts with some major modes
+
   ORG MODE
 
     - Implicit Button Support: Org-mode's local binding of {M-RET} by default

hui-menu.el

@@ -131,7 +131,7 @@ Return t if cutoff, else nil."
   (nconc
    (list
     (vector (hui-menu-key-binding-item "Action-Key          \t\t\t" 'hkey-either)                        '(hui:bind-key #'hkey-either) t)                    ;; {M-RET}
-    (vector (hui-menu-key-binding-item "Button-Rename-Key   \t"     'hui:ebut-rename)                    '(hui:bind-key #'hui:ebut-rename) t)                ;; {C-c C-r}
+    (vector (hui-menu-key-binding-item "Button-Rename-Key   \t"     'hui:ebut-rename)                    '(hui:bind-key #'hui:ebut-rename) t)                ;; None
     (vector (hui-menu-key-binding-item "Drag-Emulation-Key  \t\t"   'hkey-operate)                       '(hui:bind-key #'hkey-operate) t)                   ;; {M-o}
     (vector (hui-menu-key-binding-item "Find-Web-Key        \t\t"   'hui-search-web)                     '(hui:bind-key #'hui-search-web) t)                 ;; {C-c /}
     (vector (hui-menu-key-binding-item "Grid-of-Windows-Key \t"     'hycontrol-windows-grid)             '(hui:bind-key #'hycontrol-windows-grid) t)         ;; {C-c @}

hui-mini.el

@@ -456,7 +456,7 @@ constructs.  If not given, the top level Hyperbole menu is used."
        '(cust-keys .
          (("Change Keys>")
 	  ("ActionKey"     (hui:bind-key #'hkey-either))                        ;; {M-RET}
-	  ("ButRename"     (hui:bind-key #'hui:ebut-rename))                    ;; {C-c C-r}
+	  ("ButRename"     (hui:bind-key #'hui:ebut-rename))                    ;; None
 	  ("DragKey"       (hui:bind-key #'hkey-operate))                       ;; {M-o}
 	  ("FindWeb"       (hui:bind-key #'hui-search-web)) 	                ;; {C-c /}
 	  ("GridOfWindows" (hui:bind-key #'hycontrol-windows-grid))             ;; {C-c @}

hyperbole.el

@@ -256,11 +256,10 @@ Entry format is: (key-description key-sequence key-binding)."
     ;; Don't override prior global bindings of this key.
     (hkey-maybe-global-set-key "\C-c@" 'hycontrol-windows-grid t)
     ;;
-    ;; Binds {C-c C-r} as a site standard way of performing explicit
-    ;; button renames without invoking the Hyperbole menu.
-    ;;
+    ;; Explicit button renames without invoking the Hyperbole menu.
+    ;; No binding by default.
     ;; Don't override prior global bindings of this key.
-    (hkey-maybe-global-set-key "\C-c\C-r" 'hui:ebut-rename t)
+    ;; (hkey-maybe-global-set-key "\C-cr" 'hui:ebut-rename t)
     ;;
     ;; Binds {C-c RET} to select larger and larger synctactical units in a
     ;; buffer when invoked repeatedly, showing in the minibuffer the type

man/hyperbole.texi

@@ -3029,15 +3029,12 @@ button in the buffer will be renamed.
 
 @vindex file, .emacs
 @vindex file, hyperbole.el
-@kindex C-c C-r
 @findex hui:ebut-rename
 The rename command may be invoked from the Hyperbole menu via
-Ebut/Rename.  A faster method is to use a key bound to the
-@code{hui:ebut-rename} command.  Hyperbole typically binds this to
-@bkbd{C-c C-r}.  @bkbd{C-h w hui:ebut-rename @key{RET}} will show
-what if any key runs it.  If no key binding has been established or if
-you prefer one of your own, simply bind it within your @file{~/.emacs}
-file: @code{(global-set-key "\C-c\C-r" 'hui:ebut-rename)}.
+Ebut/Rename.  Hyperbole does not bind this command to a key by default.
+@bkbd{C-h w hui:ebut-rename @key{RET}} will show what if any key is bound
+within your Emacs.  Bind it within your @file{~/.emacs} file with:
+@code{(global-set-key "\C-cr" 'hui:ebut-rename)}, for example.
 
 
 @node Deletion, Modification, Renaming, Utilizing Explicit Buttons
@@ -7189,11 +7186,6 @@ bound prior to loading Hyperbole.
 For further details, see the @bkbd{@@} key binding description
 in @ref{HyControl}.
 
-@cindex key binding, C-c C-r
-@kitem C-c C-r
-Button Rename: Rename an explicit button. This binding is made only if
-the key is not bound prior to loading Hyperbole.
-
 @cindex key binding, M-o
 @kitem M-o
 Drag Operation: Keyboard emulation of the start and stop of mouse