Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPD-30373 wip #560

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

LPD-30373 wip #560

wants to merge 6 commits into from

Conversation

ruben-pulido
Copy link
Owner

master

… previous to changes in LPD-26157 (a889a53).

This fixes testAddUnlocalizedFriendlyURLEntryWithLocalizedAssetCategories, testAddFriendlyURLEntryWithAssetCategories and testAddFriendlyURLEntryWithLocalizedAssetCategories in FriendlyURLEntryLocalServiceTest.
… asset in a different order as they were created.

The requirements of the associated story state that 'The slug is built in the order the user selects the categories in the field “Add included to URL”'
https://liferay.atlassian.net/browse/LPD-6814#:~:text=The%20slug%20is%20built%20in%20the%20order%20the%20user%20selects%20the%20categories%20in%20the%20field%20%E2%80%9CAdd%20included%20to%20URL%E2%80%9D
…of AssetEntryAssetCategoryRelAssetCategoryIdComparator so categories are returned in the order they were linked to the asset and not if the order they were added to the vocabulary.
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@ruben-pulido ruben-pulido changed the title LPD-30373 LPD-30373 wip Jul 4, 2024
Copy link

Please resolve conflicts so we can continue reviewing and processing.

Created by PR_Conflicts_Alert[bot]

13 similar comments
Copy link

Please resolve conflicts so we can continue reviewing and processing.

Created by PR_Conflicts_Alert[bot]

Copy link

Please resolve conflicts so we can continue reviewing and processing.

Created by PR_Conflicts_Alert[bot]

Copy link

Please resolve conflicts so we can continue reviewing and processing.

Created by PR_Conflicts_Alert[bot]

Copy link

Please resolve conflicts so we can continue reviewing and processing.

Created by PR_Conflicts_Alert[bot]

Copy link

Please resolve conflicts so we can continue reviewing and processing.

Created by PR_Conflicts_Alert[bot]

Copy link

Please resolve conflicts so we can continue reviewing and processing.

Created by PR_Conflicts_Alert[bot]

Copy link

Please resolve conflicts so we can continue reviewing and processing.

Created by PR_Conflicts_Alert[bot]

Copy link

Please resolve conflicts so we can continue reviewing and processing.

Created by PR_Conflicts_Alert[bot]

Copy link

Please resolve conflicts so we can continue reviewing and processing.

Created by PR_Conflicts_Alert[bot]

Copy link

Please resolve conflicts so we can continue reviewing and processing.

Created by PR_Conflicts_Alert[bot]

Copy link

Please resolve conflicts so we can continue reviewing and processing.

Created by PR_Conflicts_Alert[bot]

Copy link

Please resolve conflicts so we can continue reviewing and processing.

Created by PR_Conflicts_Alert[bot]

Copy link

Please resolve conflicts so we can continue reviewing and processing.

Created by PR_Conflicts_Alert[bot]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants