-
Notifications
You must be signed in to change notification settings - Fork 43
2371-1 #175
base: master
Are you sure you want to change the base?
2371-1 #175
Conversation
2199 - 0
Added file 1.rb Add file 1.rb
Change rubocop.yml and add reek
Fix hound.yml for new rubocop.yml path
…und_inherited_configs Move disabled cops to rubocop.yml
Perform code clean-up for Rubocop Perform code clean up for Rubocop
Letting dogs out
2371/1/about_proxy_object_project.rb
Outdated
end | ||
|
||
# rubocop : disable MethodMissingSuper, MissingRespondToMissing | ||
def method_missing(method, *args, &block) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/MethodMissing: When using method_missing, define respond_to_missing? and fall back on super.
2371/1/about_proxy_object_project.rb
Outdated
@messages = [] | ||
end | ||
|
||
# rubocop : disable MethodMissingSuper, MissingRespondToMissing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint/UnneededCopDisableDirective: Unnecessary disabling of MethodMissingSuper (unknown cop), MissingRespondToMissing (unknown cop).
2371/1/about_methods.rb
Outdated
def my_private_method | ||
'a secret' | ||
end | ||
# rubocop: disable AccessModifierDeclarations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint/UnneededCopDisableDirective: Unnecessary disabling of AccessModifierDeclarations (unknown cop).
2371/1/about_message_passing.rb
Outdated
# ------------------------------------------------------------------ | ||
# rubocop : disable MissingRespondToMissing, MethodMissingSuper | ||
class WellBehavedFooCatcher | ||
def method_missing(method_name, *args, &block) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/MethodMissing: When using method_missing, define respond_to_missing? and fall back on super.
2371/1/about_message_passing.rb
Outdated
end | ||
|
||
# ------------------------------------------------------------------ | ||
# rubocop : disable MissingRespondToMissing, MethodMissingSuper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint/UnneededCopDisableDirective: Unnecessary disabling of MethodMissingSuper (unknown cop), MissingRespondToMissing (unknown cop).
2371/1/about_message_passing.rb
Outdated
|
||
class AllMessageCatcher | ||
# rubocop : disable StringLiteralsInInterpolation, MethodMissingSuper, MissingRespondToMissing, UnusedMethodArgument | ||
def method_missing(method_name, *args, &block) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/MethodMissing: When using method_missing, define respond_to_missing? and fall back on super.
2371/1/about_message_passing.rb
Outdated
# ------------------------------------------------------------------ | ||
|
||
class AllMessageCatcher | ||
# rubocop : disable StringLiteralsInInterpolation, MethodMissingSuper, MissingRespondToMissing, UnusedMethodArgument |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint/UnneededCopDisableDirective: Unnecessary disabling of MethodMissingSuper (unknown cop).
Lint/UnneededCopDisableDirective: Unnecessary disabling of MissingRespondToMissing (unknown cop).
@brutu33 тебе необходимо сделать rebase c последним мастером этого репозитория |
@taleh007 <<тебе необходимо сделать rebase c последним мастером этого репозитория>> Done |
@brutu33 |
Номер
2371
Номер задания
1
Ссылка на видео с демо
https://drive.google.com/open?id=18S6VGLKAGyYwEiLgUvHFXL2IMC8XHo1Y
Комментарии
Task1 : finish koans and test them with rubocop and reek