Add Rails/Env cop

Author: cdudas17

Diff for: CHANGELOG.md

@@ -1152,3 +1152,4 @@
 [@fwolfst]: https://github.com/fwolfst
 [@maxprokopiev]: https://github.com/maxprokopiev
 [@ytjmt]: https://github.com/ytjmt
+[@cdudas17]: https://github.com/cdudas17

Diff for: changelog/new_env_cop.md

@@ -0,0 +1 @@
+* [#1375](https://github.com/rubocop/rubocop-rails/pull/1375): Add new `Rails/Env` cop. ([@cdudas17][])

Diff for: config/default.yml

@@ -441,6 +441,11 @@ Rails/EnumUniqueness:
   Include:
     - app/models/**/*.rb
 
+Rails/Env:
+  Description: 'Use Feature Flags instead of `Rails.env`.'
+  Enabled: pending
+  VersionAdded: '<<next>>'
+
 Rails/EnvLocal:
   Description: 'Use `Rails.env.local?` instead of `Rails.env.development? || Rails.env.test?`.'
   Enabled: pending

Diff for: lib/rubocop/cop/rails/env.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Rails
+      # Checks for usage of `Rails.env` which can be replaced with Feature Flags
+      #
+      # @example
+      #
+      #   # bad
+      #   Rails.env.development? || Rails.env.production? || Rails.env.local?
+      #
+      #   # good
+      #   if Feature.enabled?(:new_feature)
+      #     # new feature code
+      #   end
+      #
+      class Env < Base
+        MSG = 'Use Feature Flags instead of `Rails.env`.'
+        # RESTRICT_ON_SEND = %i[env].freeze
+
+        def_node_matcher :rails_env_any?, <<~PATTERN
+          (send (send (const {nil? cbase} :Rails) :env) ...)
+        PATTERN
+
+        def on_send(node)
+          rails_env_any?(node) do
+            add_offense(node)
+          end
+        end
+      end
+    end
+  end
+end

Diff for: lib/rubocop/cop/rails_cops.rb

@@ -48,6 +48,7 @@
 require_relative 'rails/enum_hash'
 require_relative 'rails/enum_syntax'
 require_relative 'rails/enum_uniqueness'
+require_relative 'rails/env'
 require_relative 'rails/env_local'
 require_relative 'rails/environment_comparison'
 require_relative 'rails/environment_variable_access'

Diff for: spec/rubocop/cop/rails/env_spec.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+RSpec.describe RuboCop::Cop::Rails::Env, :config do
+  it 'registers an offense for `Rails.env.development? || Rails.env.test?`' do
+    expect_offense(<<~RUBY)
+      Rails.env.development? || Rails.env.test?
+                                ^^^^^^^^^^^^^^^ Use Feature Flags instead of `Rails.env`.
+      ^^^^^^^^^^^^^^^^^^^^^^ Use Feature Flags instead of `Rails.env`.
+    RUBY
+  end
+
+  it 'registers an offense for `Rails.env.production?`' do
+    expect_offense(<<~RUBY)
+      Rails.env.production?
+      ^^^^^^^^^^^^^^^^^^^^^ Use Feature Flags instead of `Rails.env`.
+    RUBY
+  end
+
+  it 'does not register an offense for unrelated config' do
+    expect_no_offenses(<<~RUBY)
+      Rails.environment
+    RUBY
+  end
+end