Improve tests unless post_location_helper.rb

Author: sandramu26

.env

@@ -15,5 +15,5 @@ TWITTER_CONSUMER_SECRET='yDwjEx8b16CJ1JZYIze2N1HnfvNkLHJX1HVsy1m4PUsZMCDo5J'
 TWITTER_ACCESS_TOKEN='3302775980-goahLve7pwL5RucNtb2UR3kVHj7F66LhjqLMCJf'
 TWITTER_ACCESS_SECRET='jjKsUZFECizNnjZnuG3pMmXrdp1nBY449y3HhXVnrGsuy'
 MAIL_NOTIFICATION='[email protected]'
-CLIENT_KEY= ''
-ACCESS_TOKEN= ''
+CLIENT_KEY= 'ZEGYIdaRKJ4eFpqjOrX6dw(('
+ACCESS_TOKEN= 'h5Q5iW2AAJSr0n4bB7(shA))'

Gemfile

@@ -65,6 +65,7 @@ group :test do
   # gem 'webmock'
   gem 'codeclimate-test-reporter', require: false
   gem 'webmock', '~> 1.14'
+  gem 'database_cleaner'
 end
 
 # api

Gemfile.lock

@@ -35,7 +35,7 @@ GEM
       tzinfo (~> 0.3.37)
     addressable (2.3.8)
     arel (4.0.2)
-    autoprefixer-rails (5.2.1.1)
+    autoprefixer-rails (5.2.1.2)
       execjs
       json
     bcrypt (3.1.10)
@@ -52,7 +52,7 @@ GEM
       rack (>= 1.0.0)
       rack-test (>= 0.5.4)
       xpath (~> 2.0)
-    celluloid (0.16.0)
+    celluloid (0.16.1)
       timers (~> 4.0.0)
     chronic (0.10.2)
     clearance (1.10.1)
@@ -73,6 +73,7 @@ GEM
     crack (0.4.2)
       safe_yaml (~> 1.0.0)
     daemons (1.2.3)
+    database_cleaner (1.4.1)
     diff-lcs (1.2.5)
     docile (1.1.5)
     dotenv (2.0.2)
@@ -84,7 +85,7 @@ GEM
     equalizer (0.0.11)
     erubis (2.7.0)
     eventmachine (1.0.8)
-    execjs (2.5.2)
+    execjs (2.6.0)
     factory_girl (4.4.0)
       activesupport (>= 3.0.0)
     factory_girl_rails (4.4.1)
@@ -124,13 +125,12 @@ GEM
     jquery-rails (3.1.3)
       railties (>= 3.0, < 5.0)
       thor (>= 0.14, < 2.0)
-    json (1.8.1)
-    jwt (0.1.8)
-      multi_json (>= 1.5)
+    json (1.8.3)
+    jwt (1.5.1)
     launchy (2.4.3)
       addressable (~> 2.3)
-    libv8 (3.16.14.7)
-    listen (3.0.0)
+    libv8 (3.16.14.11)
+    listen (3.0.3)
       rb-fsevent (>= 0.9.3)
       rb-inotify (>= 0.9)
     lumberjack (1.0.9)
@@ -147,7 +147,7 @@ GEM
     multipart-post (2.0.0)
     naught (1.0.0)
     nenv (0.2.0)
-    newrelic_rpm (3.12.1.298)
+    newrelic_rpm (3.13.0.299)
     nokogiri (1.6.6.2)
       mini_portile (~> 0.6.0)
     notiffany (0.0.7)
@@ -320,6 +320,7 @@ DEPENDENCIES
   clearance
   codeclimate-test-reporter
   coffee-rails (~> 4.0.0)
+  database_cleaner
   dotenv-rails
   factory_girl_rails (~> 4.4.0)
   guard

app/helpers/post_location_helper.rb

@@ -8,7 +8,7 @@ def link_to_post(post)
   end
 
   def show_votes(post)
-      if post.type == "InternalPost"
+    if post.type == "InternalPost"
       if post.has_voted?(current_user)
         ("<span class='fa fa-chevron-up'></span><br/>" +
         "<span> #{post.votes.count} </span><br/>" +

app/mailers/comment_mailer.rb

@@ -4,7 +4,7 @@ def send_notification_email(comment_id)
     @user = User.find @comment.parent.user_id
     @parent_id = @comment.parent_id
     @post = InternalPost.find @parent_id
-    @url = "https://www.rubygamedev.com/internal_posts/#{@parent_id}"
+    @url = "https://www.rubygamedev.com/posts/#{@parent_id}"
 
     attachments.inline['reply-button.png'] = File.read("#{Rails.root}/app/assets/images/reply-button.png")
     attachments.inline['banner-header.png'] = File.read("#{Rails.root}/app/assets/images/banner-header.png")

app/models/external_post.rb

@@ -1,6 +1,5 @@
 class ExternalPost < Post
   validates :external_id, uniqueness: true
-  # after_create :question_tag
 
   def username
     self.user_display_name
@@ -10,7 +9,4 @@ def number_of_comments
     0
   end
 
-  # def question_tag
-  #   tags.create(title: "question")
-  # end
 end

app/models/internal_post.rb

@@ -1,10 +1,8 @@
 class InternalPost < Post
   belongs_to :user
-  validates :user, presence: true
+  validates :user, :title, :body_markdown, presence: true
   has_many :comments, as: :parent
 
-  validates_presence_of :user, :title, :body_markdown
-
   before_save do
     parser = Redcarpet::Markdown.new(Redcarpet::Render::HTML, autolink: true)
     self.body_html = parser.render(body_markdown)

spec/factories/external_post.rb

@@ -1,6 +1,6 @@
 FactoryGirl.define do
   factory :external_post do
-    sequence(:external_id) { |n| "00000#{n}" }
+    sequence(:external_id) { |n| "1#{n}" }
     title "Example Discussion"
     body_markdown "Example body. So **strong**."
     user_display_name "Mister Tes"

spec/factories/internal_post.rb

@@ -1,7 +1,6 @@
 FactoryGirl.define do
   factory :internal_post do
     user
-    tags { [FactoryGirl.create(:tag)] }
     title "Example Discussion"
     body_markdown "Example body. So **strong**."
   end

spec/factories/post.rb

@@ -1,6 +1,6 @@
 FactoryGirl.define do
   factory :post do
-    user
+    tags { [FactoryGirl.create(:tag)] }
     title 'Example Discussion'
     body_markdown 'Example body. So **strong**.'
   end

spec/factories/tag.rb

@@ -1,6 +1,5 @@
 FactoryGirl.define do
   factory :tag do
     title "example"
-    user
   end
 end

spec/fixtures/vcr_cassettes/questions.yml

@@ -14,16 +14,17 @@
     end
   end
 
-  describe "#show_tags" do
-    let(:external_post) { FactoryGirl.create(:external_post) }
+  describe "#show_votes" do
     let(:internal_post) { FactoryGirl.create(:internal_post) }
 
-    it "returns questions tags" do
-      expect(helper.show_tags(external_post)).to match("question")
-    end
+    # it "returns 1 if current user has voted" do
+    #   expect(helper.show_votes(internal_post)
+    #   ).to match();
+    # end
 
-    it "returns ruby tag" do
-      expect(helper.show_tags(internal_post)).to match("example")
-    end
+    # it "returns 1 if current user has voted" do
+    #   expect(helper.show_votes(internal_post)
+    #   ).to match();
+    # end
   end
 end

spec/helpers/post_location_helper_spec.rb

@@ -23,7 +23,7 @@
 
     it "assigns @confirmation_url" do
       expect(mail.body.encoded).to match(
-        "https://www.rubygamedev.com/internal_posts/#{comment.parent_id}")
+        "https://www.rubygamedev.com/posts/#{comment.parent_id}")
     end
 
     it "render the body email" do

spec/mailers/comment_mailer_spec.rb

@@ -5,10 +5,11 @@
   it { should have_many :comments }
   it { should validate_presence_of :user }
   it { should validate_presence_of :title }
+  it { should validate_presence_of :body_markdown }
 
   describe "#notify_twitter" do
     subject { FactoryGirl.build(:internal_post) }
-
+    
     it "posts to Twitter after create" do
       expect(subject).to receive(:notify_twitter)
       subject.save!
@@ -114,7 +115,7 @@ def post_tag_titles
 
       all_tag_titles = Tag.all.map(&:title)
       expect(all_tag_titles).to match_array [
-        "example",
+        "question",
         "ruby",
         "rails",
         "great",

spec/models/internal_post_spec.rb

@@ -3,4 +3,18 @@
 describe Post do
   it { should validate_presence_of :title }
   it { should have_and_belong_to_many :tags }
+   
+  let(:post) { FactoryGirl.create :external_post  }
+  let(:post2) { FactoryGirl.create :external_post }
+
+  it "checks if a tag title question already exists in other posts" do
+
+    post.question_tag
+    post2.question_tag
+      
+    all_tag_titles = Tag.all.map(&:title)
+    expect(all_tag_titles).to match_array ["question"]
+
+  end
 end
+

spec/models/post_spec.rb

@@ -1,7 +1,6 @@
 require "rails_helper"
 
 describe Tag do
-  it { should belong_to :user }
   it { should have_and_belong_to_many :posts }
 
   # TODO

spec/models/tag_spec.rb

@@ -14,6 +14,23 @@
   config.mock_with :rspec do |mocks|
     mocks.verify_partial_doubles = true
   end
+
+  config.before(:suite) do
+    DatabaseCleaner.clean_with(:truncation)
+  end
+
+  config.before(:each) do
+    DatabaseCleaner.strategy = :transaction
+  end
+
+  config.before(:each) do
+    DatabaseCleaner.start
+  end
+
+  config.after(:each) do
+    DatabaseCleaner.clean
+  end
+
 end
 
 VCR.configure do |c|