Support Ruby 3.4 #216
Open
Support Ruby 3.4 #216
+81
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the latest `wasm-wasi`, the following warnings are shown on TryRuby. ``` `RubyGems' were not loaded. `error_highlight' was not loaded. `did_you_mean' was not loaded. `syntax_suggest' was not loaded. ``` This warnings come from `gem_prelude.rb`. https://github.com/ruby/ruby/blob/master/gem_prelude.rb I assume this this is because the current usage of `ruby.wasm` on TryRuby don't consider RubyGems and fails to load it. We should change the structure of how to use `ruby.wasm` for fixing this. But, this is just warnings and there are no other issues. And, it seems that this warnings would not be shown in Ruby 3.5 ruby/ruby@4e303fd ruby/ruby@e9dadf1 So I fixed to just silence those warnings.
y-yagi
force-pushed
the
support_ruby34_latest
branch
from
d8cc266 to
17ce458
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CRuby 3.4 and using it as default. This PR also bump js libraries to support CRuby 3.4. This PR includes the following commits.
gem_prelude. 02e51b1wasm-wasi, the some warnings are shown. I assume this this is because the current usage ofruby.wasmon TryRuby don't consider RubyGems and fails to load it. But, this is just warnings and there are no other issues. And, it seems that this warnings would not be shown in Ruby 3.5. So I fixed to just silence those warnings.Hash#inspecthas changed({:mediocre=>2}->{mediocre: 2}). I added the answer to match with the new format.