Skip to content

Commit 075d1de

Browse files
committed
Review response to #931 (review)
1 parent 0c32d82 commit 075d1de

File tree

7 files changed

+0
-14
lines changed

7 files changed

+0
-14
lines changed

gems/activerecord/6.0/activerecord-6.0.rbs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,6 @@ interface _ActiveRecord_Relation[Model, PrimaryKey] # rubocop:disable RBS/Lint/T
159159
| () { (Model) -> boolish } -> ::Integer
160160
| (Symbol | String column_name) -> ::Integer
161161

162-
# https://github.com/rails/rails/blob/v6.0.6.1/activerecord/lib/active_record/relation/query_methods.rb#L93
163-
# https://github.com/rails/rails/blob/v6.0.6.1/activerecord/lib/active_record/relation.rb#L7
164162
def order_values: () -> Array[String | Symbol]?
165163
def joins_values: () -> Array[String | Symbol]?
166164
def left_outer_joins_values: () -> Array[String | Symbol]?

gems/activerecord/6.1/activerecord-6.1.rbs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,8 +205,6 @@ interface _ActiveRecord_Relation[Model, PrimaryKey] # rubocop:disable RBS/Lint/T
205205
| () { (Model) -> boolish } -> ::Integer
206206
| (Symbol | String column_name) -> ::Integer
207207

208-
# https://github.com/rails/rails/blob/v6.1.7.10/activerecord/lib/active_record/relation/query_methods.rb#L102
209-
# https://github.com/rails/rails/blob/v6.1.7.10/activerecord/lib/active_record/relation.rb#L7
210208
def order_values: () -> Array[String | Symbol]?
211209
def joins_values: () -> Array[String | Symbol]?
212210
def left_outer_joins_values: () -> Array[String | Symbol]?

gems/activerecord/7.0/activerecord-7.0.rbs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,8 +250,6 @@ interface _ActiveRecord_Relation[Model, PrimaryKey] # rubocop:disable RBS/Lint/T
250250
| (Symbol | String column_name) -> ::Integer
251251
def sole: () -> Model
252252

253-
# https://github.com/rails/rails/blob/v7.0.8.7/activerecord/lib/active_record/relation/query_methods.rb#L151
254-
# https://github.com/rails/rails/blob/v7.0.8.7/activerecord/lib/active_record/relation.rb#L7
255253
def order_values: () -> Array[String | Symbol]?
256254
def joins_values: () -> Array[String | Symbol]?
257255
def left_outer_joins_values: () -> Array[String | Symbol]?

gems/activerecord/7.1/activerecord-7.1.rbs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -316,8 +316,6 @@ interface _ActiveRecord_Relation[Model, PrimaryKey] # rubocop:disable RBS/Lint/T
316316
| (Symbol | String column_name) -> ::Integer
317317
def sole: () -> Model
318318

319-
# https://github.com/rails/rails/blob/v7.1.5.2/activerecord/lib/active_record/relation/query_methods.rb#L159
320-
# https://github.com/rails/rails/blob/v7.1.5.2/activerecord/lib/active_record/relation.rb#L7
321319
def order_values: () -> Array[String | Symbol]?
322320
def joins_values: () -> Array[String | Symbol]?
323321
def left_outer_joins_values: () -> Array[String | Symbol]?

gems/activerecord/7.2/activerecord-7.2.rbs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -325,8 +325,6 @@ interface _ActiveRecord_Relation[Model, PrimaryKey] # rubocop:disable RBS/Lint/T
325325
| (Symbol | String column_name) -> ::Integer
326326
def sole: () -> Model
327327

328-
# https://github.com/rails/rails/blob/v7.2.2.2/activerecord/lib/active_record/relation/query_methods.rb#L175
329-
# https://github.com/rails/rails/blob/v7.2.2.2/activerecord/lib/active_record/relation.rb#L55
330328
def order_values: () -> Array[String | Symbol]?
331329
def joins_values: () -> Array[String | Symbol]?
332330
def left_outer_joins_values: () -> Array[String | Symbol]?

gems/activerecord/8.0/activerecord-8.0.rbs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -325,8 +325,6 @@ interface _ActiveRecord_Relation[Model, PrimaryKey] # rubocop:disable RBS/Lint/T
325325
| (Symbol | String column_name) -> ::Integer
326326
def sole: () -> Model
327327

328-
# https://github.com/rails/rails/blob/v8.0.2.1/activerecord/lib/active_record/relation.rb#L55
329-
# https://github.com/rails/rails/blob/v8.0.2.1/activerecord/lib/active_record/relation/query_methods.rb#L178
330328
def order_values: () -> Array[String | Symbol]?
331329
def joins_values: () -> Array[String | Symbol]?
332330
def left_outer_joins_values: () -> Array[String | Symbol]?

gems/railties/6.0/railties.rbs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ module Rails
2323
# Defines the routes for this engine. If a block is given to
2424
# routes, it is appended to the engine.
2525
def routes: () ?{ () [self: Mapper] -> void } -> ActionDispatch::Routing::RouteSet
26-
# https://github.com/rails/rails/blob/v6.0.6.1/railties/lib/rails/engine.rb#L537
27-
# https://github.com/rails/rails/blob/v6.0.6.1/actionpack/lib/action_dispatch/routing/route_set.rb#L421
2826
end
2927
end
3028

0 commit comments

Comments
 (0)