Skip to content

Inline annotations #2403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 14, 2025
Merged

Inline annotations #2403

merged 15 commits into from
Apr 14, 2025

Conversation

@soutaro
Copy link
Member

@soutaro soutaro commented Apr 14, 2025 •
edited
Loading

Add some inline type declaration of methods.

class Foo
  # @rbs () -> void
  #: (String) -> Integer
  def foo(x) = 123

  def bar #: void
  end
end

@soutaro soutaro added this to the RBS 4.0 milestone Apr 14, 2025
@soutaro soutaro enabled auto-merge April 14, 2025 08:14
@soutaro soutaro force-pushed the inline-annotations branch from 8cc6258 to de06b01 Compare April 14, 2025 08:34
@soutaro soutaro added this pull request to the merge queue Apr 14, 2025
Merged via the queue into master with commit 674dbdf Apr 14, 2025
20 checks passed
@soutaro soutaro deleted the inline-annotations branch April 14, 2025 08:42
@st0012 st0012 mentioned this pull request Apr 25, 2025
Merged
st0012 added a commit to Shopify/rbs that referenced this pull request Apr 30, 2025
@st0012 @soutaro
@dependabot @amomchilov
Merge master and support upstream's parser enhancements (#41)
21752fb 
`ruby/rbs` recently received a few enhancements for new keywords and
inline parsing:

- ruby#2403
- ruby#2405
- ruby#2406

So the major change of this PR is to reimplement them under the `c-api`
structure.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Soutaro Matsumoto <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alexander Momchilov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

RBS 4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@soutaro