Merge pull request #5317 from Benjamin-Couey/3689-check-double-clicks-on-submit

3689 check double clicks on submit

Author: awwaiid

app/helpers/ui_helper.rb

@@ -162,8 +162,11 @@ def _link_to(link, options = {}, properties = {})
     text = options[:text]
     size = options[:size]
     type = options[:type]
+
+    properties[:data] ||= {}
+    properties[:data][:disable_with] ||= "Please wait..."
+
     if options[:data].present?
-      properties[:data] ||= {}
       properties[:data].merge!(options[:data])
     end
     properties[:title] = options[:title] if options[:title].present?
@@ -180,7 +183,7 @@ def _link_to(link, options = {}, properties = {})
     end
   end
 
-  def _button_to(options = {}, other_properties = {})
+  def _button_to(options = {}, properties = {})
     submit_type = options[:submit_type] || "submit"
     id = options[:id]
     type = options[:type]
@@ -189,7 +192,10 @@ def _button_to(options = {}, other_properties = {})
     text = options[:text]
     align = options[:align]
 
-    button_tag({ type: submit_type, id: id, class: "btn btn-#{type} btn-#{size} #{align}" }.merge(other_properties)) do
+    properties[:data] ||= {}
+    properties[:data][:disable_with] ||= "Please wait..."
+
+    button_tag({ type: submit_type, id: id, class: "btn btn-#{type} btn-#{size} #{align}" }.merge(properties)) do
       fa_icon icon, text: text
     end
   end

app/views/partner_users/_user.html.erb

@@ -49,14 +49,14 @@
             </td>
             <td class='d-flex flex-column'>
               <% unless user.invitation_accepted_at %>
-                <%= button_to resend_invitation_partner_user_path(partner, user), method: :post, class: "btn btn-warning btn-xs mb-2" do %>
+                <%= button_to resend_invitation_partner_user_path(partner, user), method: :post, data: { disable_with: "Please wait..." }, class: "btn btn-warning btn-xs mb-2" do %>
                   <i class="fa fa-envelope"></i> Resend Invitation
                 <% end %>
               <% end %>
-              <%= button_to reset_password_partner_user_path(partner, user), method: :post, data: { confirm: "Are you sure?" }, class: "btn btn-info btn-xs mb-2" do %>
+              <%= button_to reset_password_partner_user_path(partner, user), method: :post, data: { confirm: "Are you sure?", disable_with: "Please wait..." }, class: "btn btn-info btn-xs mb-2" do %>
                   <i class="fa fa-key"></i> Reset Password
               <% end %>
-              <%= button_to partner_user_path(partner, user), method: :delete, data: { confirm: "Are you sure?" }, class: "btn btn-danger btn-xs" do %>
+              <%= button_to partner_user_path(partner, user), method: :delete, data: { confirm: "Are you sure?", disable_with: "Please wait..." }, class: "btn btn-danger btn-xs" do %>
                   <i class="fa fa-ban"></i> Remove Access
               <% end %>
 

app/views/partner_users/_users.html.erb

@@ -39,7 +39,7 @@
     <% when "awaiting_review" %>
       <%= view_button_to partner_path(partner_row) + "#partner-information", { text: "Review Applicant's Profile", icon: "check", type: "warning" } %>
     <% when "approved" %>
-      <%= button_to recertify_partner_partner_path(partner_row), data: { confirm: "Recertify partner #{partner_row.name}?"}, class: "btn btn-xs bg-red" do %>
+      <%= button_to recertify_partner_partner_path(partner_row), data: { confirm: "Recertify partner #{partner_row.name}?", disable_with: "Please wait..."}, class: "btn btn-xs bg-red" do %>
         <i class="fa fa-refresh"></i> Request Recertification
       <% end %>
     <% when "deactivated" %>

app/views/partners/_partner_row.html.erb

@@ -22,7 +22,7 @@
   </td>
   <td class="text-right">
     <%= view_button_to request_path(request_row) %>
-    <%= button_to 'Cancel', new_request_cancelation_path(request_id: request_row.id), method: :get, class: 'btn btn-danger btn-xs' %>
+    <%= button_to 'Cancel', new_request_cancelation_path(request_id: request_row.id), method: :get, data: { disable_with: "Please wait..." }, class: 'btn btn-danger btn-xs' %>
     <%= print_button_to print_picklist_request_path(request_row), { format: :pdf, text: "Print", size: "xs" } %>
     </td>
 </tr>

app/views/requests/_request_row.html.erb

@@ -110,7 +110,7 @@
             <%= view_button_to(distribution_path(@request.distribution), {text: "View Associated Distribution", size: "md"}) if @request.distribution %>
             <%= print_button_to print_picklist_request_path(@request), { format: :pdf, text: "Print", size: "md" } %>
             <%= button_to 'Cancel', new_request_cancelation_path(request_id: @request.id),
-                          method: :get, form_class: 'd-inline', class: 'btn btn-danger btn-md' %>
+                          method: :get, data: { disable_with: "Please wait..." }, form_class: 'd-inline', class: 'btn btn-danger btn-md' %>
           </div>
         </div>
       </div>

app/views/requests/show.html.erb

@@ -0,0 +1,24 @@
+# Simulates the user double clicking on an element specified by a css_selector
+# by using the API provided by Ferrum to manipulate the browser directly.
+#
+# @param css_selector [String] The CSS selector for the element to be double clicked.
+#
+# @example Usage
+#   # Make sure the element is there
+#   expect(page.find('a.btn.btn-success.btn-md[href*="/picked_up"]')).to have_content("Distribution Complete")
+#
+#   # Double click it
+#   ferrum_double_click('a.btn.btn-success.btn-md[href*="/picked_up"]')
+#
+#   # Assert something based on the double click.
+def ferrum_double_click(css_selector)
+  node = Capybara.page.driver.browser.at_css(css_selector)
+  x, y = node.find_position
+  mouse = node.page.mouse
+  mouse.move(x:, y:)
+  mouse.down
+  mouse.up
+  sleep(0.05)
+  mouse.down
+  mouse.up
+end

spec/support/double_click_helper.rb

@@ -887,4 +887,41 @@
 
     expect(page).to have_content("This distribution has been marked as being completed!")
   end
+
+  it "Double clicking distribution complete does not result in the distribution attemping to be completed twice" do
+    visit new_distribution_path
+    item = View::Inventory.new(organization.id).items_for_location(storage_location.id).first.db_item
+    TestInventory.create_inventory(organization,
+      {
+        storage_location.id => { item.id => 20 }
+      })
+
+    select "Test Partner", from: "Partner"
+    select "Test Storage Location", from: "From storage location"
+    choose "Delivery"
+    select item.name, from: "distribution_line_items_attributes_0_item_id"
+    fill_in "distribution_line_items_attributes_0_quantity", with: 15
+
+    click_button "Save"
+
+    within "#distributionConfirmationModal" do
+      click_button "Yes, it's correct"
+    end
+
+    # Make sure the button is there before trying to double click it
+    expect(page.find('a.btn.btn-success.btn-md[href*="/picked_up"]')).to have_content("Distribution Complete")
+
+    # Double click on the Distribution complete button
+    ferrum_double_click('a.btn.btn-success.btn-md[href*="/picked_up"]')
+
+    # Capybara will be quick to determine that a screen doesn't have content.
+    # Make some positive assertions that only appears on the new screen to make
+    # sure it's loaded before asserting something isn't there.
+    expect(page).not_to have_content("Distribution Complete")
+    expect(page).to have_content("Complete")
+
+    # If it tries to mark the distribution as completed twice, the second time
+    # will fail (the distribution is already complete) and show this error
+    expect(page).not_to have_content("Sorry, we encountered an error when trying to mark this distribution as being completed")
+  end
 end

spec/system/distribution_system_spec.rb

@@ -30,6 +30,29 @@
 
           expect(partner_awaiting_approval.reload.approved?).to eq(true)
         end
+
+        it 'Double clicking approval button does not result in the partner attemping to be approved twice' do
+          visit partners_path
+
+          assert page.has_content? partner_awaiting_approval.name
+          click_on "Review Applicant's Profile"
+
+          # Make sure the button is there before trying to double click it
+          expect(page.find('a.btn.btn-success.btn-md[href*="/approve_application"]')).to have_content("Approve Partner")
+
+          # Double click on the Distribution complete button
+          ferrum_double_click('a.btn.btn-success.btn-md[href*="/approve_application"]')
+
+          # Capybara will be quick to determine that a screen doesn't have content.
+          # Make some positive assertions that only appears on the new screen to make
+          # sure it's loaded before asserting something isn't there.
+          expect(page).to have_content("Partner Agencies for")
+
+          # If it tries to mark the partner as approved twice, the second time
+          # will fail (the partner is already approved) and show this error
+          expect(page).not_to have_content('Failed to approve partner because: ["partner is not waiting for approval"]')
+          # TODO: Verify multiple emails aren't sent?
+        end
       end
 
       context 'when the approval does not succeed' do