Move content regexp to article

Author: marocchino

_plugins/generators.rb

@@ -2,29 +2,31 @@
 
 class RSSGenerator < Jekyll::Generator
   def generate(site)
-    @index_page = site.pages.find { |page| page.name == "index.md" }
+    @content = site.pages.find { |page| page.name == "index.md" }.content
     site.pages.each do |page|
       page.data['articles'] = articles if %w(feed.xml rss.xml).include?(page.name)
     end
   end
 
   private
   def articles
-    @articles ||= Article.all(rows)
-  end
-
-  def rows
-    @index_page.content.split(/#articles\s*}\n\n/).last.split(/## \[동영상\]/).first.split(/\n/)
+    @articles ||= Article.all(@content)
   end
 end
 
 class Article
   ROW_MATCHER = /^-\s*\[(?<title>[^\]]+)\]\((?<url>[^)]+)\){:\s*.article(?<data>(\s*data-\w+="[^"]+")+)\s*}\s*$/
   DATA_MATCHER = /data-(?<key>\w+)="(?<value>[^"]+)"/
+  CONTEXT_MATCHER = /#articles\s*}\n+(?<rows>(#{ROW_MATCHER}\n)+)\n*## \[동영상\]/m
   InvalidRow = Class.new(RuntimeError)
+  InvalidContent = Class.new(RuntimeError)
+
   attr_reader :info
 
-  def self.all(rows)
+  def self.all(content)
+    m = content.match(CONTEXT_MATCHER)
+    raise InvalidContent, "invalid content: #{content}" unless m
+    rows = m[:rows].split("\n")
     rows.map { |row| new(row).to_h }
   end
 
@@ -37,21 +39,21 @@ def initialize(row)
   end
 
   def to_h
-    @info
+    info
   end
 
   private
   def set_title(m)
-    if @info["tags"].include?("translated")
-      @info["title"] = "[번역] #{m[:title]}"
+    if info["tags"].include?("translated")
+      info["title"] = "[번역] #{m[:title]}"
     else
-      @info["title"] = m[:title]
+      info["title"] = m[:title]
     end
   end
 
   def set_data(m)
     m[:data].scan(DATA_MATCHER) do |key, value|
-      @info[key] = value
+      info[key] = value
     end
   end
 end

spec/generators_spec.rb

@@ -6,11 +6,18 @@
 
 describe Article do
   describe ".all" do
-    subject(:articles) { Article.all([
-        '- [title](https://link.to.article){: .article data-date="2015.01.12" data-tags="translated ruby" data-author="author" }',
-        '- [title](https://link.to.article){: .article data-date="2015.01.12" data-tags="ruby" data-author="author" }',
-      ]) }
-    it { expect(articles.size).to be(2) }
+    context 'when invalid row' do
+      let(:content) { "" }
+      subject(:articles) { Article.all(content) }
+      it { expect { articles }.to raise_error Article::InvalidContent }
+    end
+
+    context 'when index.md' do
+      let(:content) { `cat index.md` }
+      subject(:articles) { Article.all(content) }
+      it { expect(articles.class).to be(Array)}
+      it { expect(articles.size).to be > 1 }
+    end
   end
 
   describe "#new" do