fix: type issues (#1663)

* fix: update consent management options types to make all fields optional

* fix: update rudderanalytics type

* fix: preloaded types

* fix: type cast

* fix: types for loading script module

Author: saikumarrs

packages/analytics-js-common/src/types/Consent.ts

@@ -31,8 +31,8 @@ export type ConsentResolutionStrategy = 'and' | 'or';
 export type Consents = string[];
 
 export type ConsentManagementOptions = {
-  enabled: boolean;
-  provider: ConsentManagementProvider;
+  enabled?: boolean;
+  provider?: ConsentManagementProvider;
   allowedConsentIds?: Consents;
   deniedConsentIds?: Consents;
 };

packages/analytics-js-common/types/rudderanalytics.d.ts

@@ -139,7 +139,7 @@ class RudderAnalytics implements IRudderAnalytics<IAnalytics> {
    */
   triggerBufferedLoadEvent() {
     const preloadedEventsArray = Array.isArray((globalThis as typeof window).rudderanalytics)
-      ? ((globalThis as typeof window).rudderanalytics as PreloadedEventCall[])
+      ? ((globalThis as typeof window).rudderanalytics as unknown as PreloadedEventCall[])
       : ([] as PreloadedEventCall[]);
 
     // The array will be mutated in the below method

packages/analytics-js/src/app/RudderAnalytics.ts

@@ -1,5 +1,5 @@
 export type PreloadedEventCall = Array<string | any>;
 
 export type RudderAnalyticsPreloader = {
-  [index: string]: (...args: number[]) => any;
+  [index: string]: (...args: any[]) => any;
 };

packages/analytics-js/src/components/preloadBuffer/types.ts

@@ -98,8 +98,8 @@ const getConsentManagerInfo = (
   consentManagementOpts: ConsentManagementOptions,
   logger?: ILogger,
 ) => {
-  let { provider }: { provider: ConsentManagementProvider | undefined } = consentManagementOpts;
-  const consentManagerPluginName = ConsentManagersToPluginNameMap[provider];
+  let { provider }: { provider?: ConsentManagementProvider } = consentManagementOpts;
+  const consentManagerPluginName = provider ? ConsentManagersToPluginNameMap[provider] : undefined;
   if (provider && !consentManagerPluginName) {
     logger?.error(
       UNSUPPORTED_CONSENT_MANAGER_ERROR(CONFIG_MANAGER, provider, ConsentManagersToPluginNameMap),

packages/analytics-js/src/components/utilities/consent.ts

@@ -1,8 +1,5 @@
 import type { RudderAnalytics } from './app/RudderAnalytics';
-import type {
-  PreloadedEventCall,
-  RudderAnalyticsPreloader,
-} from './components/preloadBuffer/types';
+import type { RudderAnalyticsPreloader } from './components/preloadBuffer/types';
 import type { IRudderStackGlobals } from './app/IRudderStackGlobals';
 
 export {
@@ -26,13 +23,13 @@ export { type IdentifyTraits } from '@rudderstack/analytics-js-common/types/trai
 export { RudderAnalytics } from './app/RudderAnalytics';
 export { type IRudderStackGlobals } from './app/IRudderStackGlobals';
 export {
-  type PreloadedEventCall,
   type RudderAnalyticsPreloader,
+  type PreloadedEventCall,
 } from './components/preloadBuffer/types';
 
 declare global {
   interface Window {
-    rudderanalytics: RudderAnalytics | PreloadedEventCall[] | RudderAnalyticsPreloader;
+    rudderanalytics: RudderAnalytics | RudderAnalyticsPreloader | undefined;
     RudderStackGlobals: IRudderStackGlobals;
     rudderAnalyticsMount: () => void;
     rudderAnalyticsBuildType: 'legacy' | 'modern';

packages/analytics-js/src/index.ts

@@ -7,7 +7,7 @@ import type {
 
 declare global {
   interface Window {
-    rudderanalytics: RudderAnalytics | PreloadedEventCall[] | RudderAnalyticsPreloader;
+    rudderanalytics: RudderAnalytics | RudderAnalyticsPreloader | undefined;
     RudderStackGlobals: IRudderStackGlobals;
     rudderAnalyticsMount: () => void;
     rudderAnalyticsBuildType: 'legacy' | 'modern';

packages/analytics-js/src/types/rudderanalytics.d.ts

@@ -18,7 +18,7 @@ const sdkName = 'rsa.min.js';
 const asyncScript = true;
 window.rudderAnalyticsBuildType = 'legacy';
 
-window.rudderanalytics = [];
+(window.rudderanalytics as unknown as PreloadedEventCall[]) = [];
 const methods: string[] = [
   'setDefaultInstanceKey',
   'load',
@@ -39,7 +39,7 @@ for (let i = 0; i < methods.length; i++) {
   const method = methods[i] as string;
   (window.rudderanalytics as unknown as RudderAnalyticsPreloader)[method] = (methodName =>
     function () {
-      (window.rudderanalytics as PreloadedEventCall[]).push(
+      (window.rudderanalytics as unknown as PreloadedEventCall[]).push(
         [methodName].concat(Array.prototype.slice.call(arguments) as PreloadedEventCall),
       );
     })(method);

packages/loading-scripts/src/index.ts

@@ -7,7 +7,7 @@ import type {
 
 declare global {
   interface Window {
-    rudderanalytics: RudderAnalytics | PreloadedEventCall[] | RudderAnalyticsPreloader;
+    rudderanalytics: RudderAnalytics | RudderAnalyticsPreloader | undefined;
     RudderStackGlobals: IRudderStackGlobals;
     rudderAnalyticsMount: () => void;
     rudderAnalyticsBuildType: 'legacy' | 'modern';

packages/loading-scripts/src/types/rudderanalytics.d.ts

@@ -7,7 +7,7 @@ import type {
 
 declare global {
   interface Window {
-    rudderanalytics: RudderAnalytics | PreloadedEventCall[] | RudderAnalyticsPreloader;
+    rudderanalytics: RudderAnalytics | RudderAnalyticsPreloader | undefined;
     RudderStackGlobals: IRudderStackGlobals;
     rudderAnalyticsMount: () => void;
     rudderAnalyticsBuildType: 'legacy' | 'modern';