From 2365e1c58b85ff6e7f47854f473fa9da51b157f8 Mon Sep 17 00:00:00 2001
From: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com>
Date: Mon, 21 Oct 2024 10:57:32 +0530
Subject: [PATCH] chore: update code owners for easier release management
 (#1894)

* chore: update code owners for easier release management

* chore: add slash to directories to apply the changes to all

* chore: pass env correctly to npm

* chore: use cross-env

* chore: try direct commit hash

* chore: specify head commit too

* chore: use env now

* chore: move base ref to global env

* chore: check for affected projects

* chore: fix all the workflows

* chore: skip fixing workflows for now

* chore: fix affected issues
---
 ...ty-code-quality-and-bundle-size-checks.yml |  5 +----
 .github/workflows/unit-tests-and-lint.yml     | 12 ++++++++----
 CODEOWNERS                                    | 13 +++++++++++--
 package-lock.json                             | 19 +++++++++++++++++++
 package.json                                  |  1 +
 5 files changed, 40 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/security-code-quality-and-bundle-size-checks.yml b/.github/workflows/security-code-quality-and-bundle-size-checks.yml
index 272ba8472..e285abe49 100644
--- a/.github/workflows/security-code-quality-and-bundle-size-checks.yml
+++ b/.github/workflows/security-code-quality-and-bundle-size-checks.yml
@@ -7,6 +7,7 @@ on:
 
 env:
   NODE_OPTIONS: "--no-warnings"
+  BASE_REF: ${{ github.event.pull_request.base.sha || 'HEAD' }}
 
 jobs:
   bundle-size-checks:
@@ -64,15 +65,11 @@ jobs:
           npm run check:duplicates
 
       - name: Build the project
-        env:
-          BASE_REF: ${{ github.event.pull_request.base.sha }}
         run: |
           npm run build:ci
           npm run build:modern:ci
 
       - name: Execute package linting checks
-        env:
-          BASE_REF: ${{ github.event.pull_request.base.sha }}
         run: |
           npm run check:pub:ci
 
diff --git a/.github/workflows/unit-tests-and-lint.yml b/.github/workflows/unit-tests-and-lint.yml
index 99c2c15f6..52898419d 100644
--- a/.github/workflows/unit-tests-and-lint.yml
+++ b/.github/workflows/unit-tests-and-lint.yml
@@ -10,6 +10,7 @@ on:
 
 env:
   NODE_OPTIONS: "--no-warnings"
+  BASE_REF: ${{ github.event.pull_request.base.sha || 'HEAD' }}
 
 jobs:
   test:
@@ -35,9 +36,14 @@ jobs:
         run: |
           npm run setup:ci
 
+      - name: Check for affected projects
+        id: check_affected
+        run: |
+          AFFECTED_PROJECTS=$(npx nx show projects --affected --base=$BASE_REF | tr '\n' ',')
+          echo "Affected projects: $AFFECTED_PROJECTS"
+          echo "affected_projects=$AFFECTED_PROJECTS" >> $GITHUB_OUTPUT
+
       - name: Execute unit tests
-        env:
-          BASE_REF: ${{ github.event.pull_request.base.sha || 'HEAD' }}
         run: |
           npm run test:ci
 
@@ -49,8 +55,6 @@ jobs:
           files: ./packages/analytics-js/reports/coverage/clover.xml,./packages/analytics-js-common/reports/coverage/clover.xml,./packages/analytics-js-integrations/reports/coverage/clover.xml,./packages/analytics-js-plugins/reports/coverage/clover.xml,./packages/analytics-js-service-worker/reports/coverage/clover.xml,./packages/analytics-v1.1/reports/coverage/clover.xml,./packages/analytics-js-cookies/reports/coverage/clover.xml
 
       - name: Execute linting check
-        env:
-          BASE_REF: ${{ github.event.pull_request.base.sha || 'HEAD' }}
         run: |
           npm run check:lint:ci
 
diff --git a/CODEOWNERS b/CODEOWNERS
index 730fd6679..ba26277d2 100644
--- a/CODEOWNERS
+++ b/CODEOWNERS
@@ -1,3 +1,12 @@
 * @rudderlabs/js-sdk
-/packages/analytics-js-integrations/ @rudderlabs/js-sdk-dm-intg-eng
-/packages/analytics-js-common/src/constants/integrations @rudderlabs/js-sdk-dm-intg-eng
+
+/packages/analytics-js-integrations/src/ @rudderlabs/js-sdk-dm-intg-eng
+/packages/analytics-js-integrations/__fixtures__/ @rudderlabs/js-sdk-dm-intg-eng
+/packages/analytics-js-integrations/__tests__/ @rudderlabs/js-sdk-dm-intg-eng
+/packages/analytics-js-integrations/__mocks__/ @rudderlabs/js-sdk-dm-intg-eng
+/packages/analytics-js-integrations/README.md @rudderlabs/js-sdk-dm-intg-eng
+/packages/analytics-js-integrations/.size-limit.js @rudderlabs/js-sdk-dm-intg-eng
+
+/packages/analytics-js-common/src/constants/integrations/ @rudderlabs/js-sdk-dm-intg-eng
+/assets/integrations/AdobeAnalytics/ @rudderlabs/js-sdk-dm-intg-eng
+/examples/integrations/ @rudderlabs/js-sdk-dm-intg-eng
diff --git a/package-lock.json b/package-lock.json
index 392a6aa1b..12385b007 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -89,6 +89,7 @@
         "commitizen": "4.3.1",
         "commitlint": "19.5.0",
         "core-js": "3.38.1",
+        "cross-env": "7.0.3",
         "dotenv": "16.4.5",
         "each": "2.7.0",
         "eslint": "8.57.0",
@@ -10483,6 +10484,24 @@
       "integrity": "sha512-dcKFX3jn0MpIaXjisoRvexIJVEKzaq7z2rZKxf+MSr9TkdmHmsU4m2lcLojrj/FHl8mk5VxMmYA+ftRkP/3oKQ==",
       "dev": true
     },
+    "node_modules/cross-env": {
+      "version": "7.0.3",
+      "resolved": "https://registry.npmjs.org/cross-env/-/cross-env-7.0.3.tgz",
+      "integrity": "sha512-+/HKd6EgcQCJGh2PSjZuUitQBQynKor4wrFbRg4DtAgS1aWO+gU52xpH7M9ScGgXSYmAVS9bIJ8EzuaGw0oNAw==",
+      "dev": true,
+      "dependencies": {
+        "cross-spawn": "^7.0.1"
+      },
+      "bin": {
+        "cross-env": "src/bin/cross-env.js",
+        "cross-env-shell": "src/bin/cross-env-shell.js"
+      },
+      "engines": {
+        "node": ">=10.14",
+        "npm": ">=6",
+        "yarn": ">=1"
+      }
+    },
     "node_modules/cross-spawn": {
       "version": "7.0.3",
       "resolved": "https://registry.npmjs.org/cross-spawn/-/cross-spawn-7.0.3.tgz",
diff --git a/package.json b/package.json
index b4e4ee524..bd2af1ad8 100644
--- a/package.json
+++ b/package.json
@@ -144,6 +144,7 @@
     "commitizen": "4.3.1",
     "commitlint": "19.5.0",
     "core-js": "3.38.1",
+    "cross-env": "7.0.3",
     "dotenv": "16.4.5",
     "each": "2.7.0",
     "eslint": "8.57.0",