-
Notifications
You must be signed in to change notification settings - Fork 18
additional property for page offset? #49
Comments
Hi, Sounds great. I would definitively merge in a PR for this (hint, hint :)) |
OK, I gave it a try. I introduced a constant a variable an a function:
in
right at the beginning in the In
I'm not sure if this will work in every situation (in particular with multiple files) but so far it works for me. |
Would you mind creating a real pull request for this? In this form, your contribution is kind of hard to review and impossible to merge. Also, with a real Pull Request ™ the tests would be run against your changes and catch any regressions. Thank you very much for your contribution and caring. |
If I understand correctly I need to push a new branch to github to create that pull request. Unfortunately I don't seem to be allowed to push to interleave. Correct?
|
Yes, correct. You're not allowed to push to the interleave repository (yet? 😉). Basically you have to fork the repository, push a branch with your changes to your fork and then you can create a pull request for that. The Github help describes this kind of workflow very well: https://help.github.com/categories/collaborating-with-issues-and-pull-requests/ and https://help.github.com/articles/creating-a-pull-request-from-a-fork/ Regards, |
Hi,
since interleave seems to allow a really smooth workflow, when annotating PDFs in emacs, I'm thinking about using it to annotate theses, something I regularly need to do. Since page 1 of a thesis usually is at page 8 to 20 of the PDF it would be great if one could set a property defining this offset. In interleave--create-new-note when the headline for the note is created, this property's value could then just be added to the page variable in (insert (format "Notes for page %d" page)). The behavior of interleave would not be changed, only headings would reflect the actual page numbers.
What do you think about that?
Cheers,
Alex
The text was updated successfully, but these errors were encountered: