Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bejeweled Twist -- Tips text not showing up #18767

Open
thenickman100 opened this issue Nov 26, 2024 · 3 comments · May be fixed by #19059
Open

Bejeweled Twist -- Tips text not showing up #18767

thenickman100 opened this issue Nov 26, 2024 · 3 comments · May be fixed by #19059
Labels
bug Something isn't working text Issues relating to text rendering/input

Comments

@thenickman100
Copy link

Describe the bug

The Bejeweled Twist game requires a separate xml file that contains all of the text for the game. Presently, all of the title text is correctly rendering from this file.

The special tips that should pop up during game play are not showing up. It just looks blank. This issue does not occur in flash player.Image
Image

Expected behavior

The tips text should appear.

Content Location

file.zip

Affected platform

Self-hosted version

Operating system

Windows 11 Home

Browser

Edge Version 131.0.2903.70 (Official build) (64-bit)

Additional information

No response

@thenickman100 thenickman100 added the bug Something isn't working label Nov 26, 2024
@kjarosh
Copy link
Member

kjarosh commented Nov 26, 2024

The text is not showing probably because it has indent equal to 3204.8. Ruffle might have calculated this value wrongly, or FP might handle such indent differently.

@kjarosh kjarosh added the text Issues relating to text rendering/input label Nov 26, 2024
@thenickman100
Copy link
Author

The text is not showing probably because it has indent equal to 3204.8. Ruffle might have calculated this value wrongly, or FP might handle such indent differently.

Unsure if this is a bug with ruffle or a bug ("feature") with Flash Player where the indent was ignored. I used FFDEC to modify the swf file and it has resolved this issue in Ruffle. Even in FFDEC, it wasn't rendering the text because of the indent.

Here are the original code snippets. I changed the value "64096" with "0".

resources --> texts --> Define EditText Child 839
[ xmin -1061 ymin -40 xmax 666 ymax 388 readonly 1 noselect 1 html 1 useoutlines 1 font 382 height 280 color #ff999999 align left leftmargin 0 rightmargin 0 indent 64096 leading -20 ]<p align="left"><font face="Continuum Bold" size="14" color="#999999" letterSpacing="0.000000" kerning="1">Turn tips Off</font></p>

resources --> texts --> Define EditText Child 830
[ xmin -1061 ymin -40 xmax 4515 ymax 1967 wordwrap 1 multiline 1 readonly 1 noselect 1 html 1 useoutlines 1 font 382 height 360 color #ffffffff align left leftmargin 0 rightmargin 0 indent 64096 leading -20 ]<p align="left"><font face="Continuum Bold" size="18" color="#ffffff" letterSpacing="0.000000" kerning="1">This LOCKED GEM can&apos;t be moved,</font></p><p align="left"><font face="Continuum Bold" size="18" color="#ffffff" letterSpacing="0.000000" kerning="1">but you can still match it!</font></p>

Here is how it looks in ruffle now
Image

Here is the modified file
bejeweledtwist.zip

@kjarosh kjarosh linked a pull request Dec 24, 2024 that will close this issue
@kjarosh
Copy link
Member

kjarosh commented Dec 24, 2024

The text is not showing probably because it has indent equal to 3204.8. Ruffle might have calculated this value wrongly, or FP might handle such indent differently.

Turns out it's both ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working text Issues relating to text rendering/input
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants