Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to download SWFs from error screen #19249

Open
ChrisCPI opened this issue Jan 16, 2025 · 5 comments
Open

Be able to download SWFs from error screen #19249

ChrisCPI opened this issue Jan 16, 2025 · 5 comments
Labels
enhancement New feature or request

Comments

@ChrisCPI
Copy link

Describe the feature
This is more of a minor annoyance than anything else.
The web extension will sometimes fail to load some SWF files from URLs with the error of "Ruffle cannot parse the requested file" or "Ruffle failed to load the Flash SWF file", even though I know for a fact these SWFs do exist on their own at the URLs.

I often need to download SWF files, but the extension automatically opens when I go to a SWF link (which is nice, don't get me wrong), and so it's annoying when this error occurs, because I then have to go manually disable the extension to be able to download the file. It would be nice if, on the error screen, there would be a button that was like "Would you like to try downloading the SWF anyway?", so I can easily download it from there.

Thanks for all of your hard work!

@ChrisCPI ChrisCPI added the enhancement New feature or request label Jan 16, 2025
@Lord-McSweeney
Copy link
Collaborator

I often need to download SWF files, but the extension automatically opens when I go to a SWF link

You can disable this by enabling the "Play SWF files in browser instead of downloading" setting.

As for the actual request, could you send an example of a link to a SWF that has that issue?

@danielhjacobs
Copy link
Contributor

by enabling

*Slight clarification: disabling; the setting is enabled by default.

@ChrisCPI
Copy link
Author

ChrisCPI commented Jan 16, 2025

by enabling the "Play SWF files in browser instead of downloading" setting.

I don't see this setting?

could you send an example of a link to a SWF that has that issue?

https://icerink.solero.me/media1.clubpenguin.com/play/v2/games/beans/bootstrap.swf

@danielhjacobs
Copy link
Contributor

danielhjacobs commented Jan 17, 2025

See video for accessing the setting. If it doesn't appear, usually that means a direct SWF link won't load in Ruffle (because the browser doesn't support the declarativeNetRequest RuleCondition needed to make that work), so if it's not there but a direct SWF link is still loading with Ruffle that's bizzare:

Screencast.From.2025-01-17.15-14-56.mp4

Regardless, it's not a bad suggestion. I'll look into it.

@danielhjacobs
Copy link
Contributor

danielhjacobs commented Jan 17, 2025

Just found by testing this, https://icerink.solero.me/media1.clubpenguin.com/play/v2/games/beans/bootstrap.swf is an HTML page made to look like an SWF.

<!DOCTYPE html>
<html style="margin:0;padding:0;">
  <head>
    <title>icerink - /src/media1.clubpenguin.com/play/v2/games/beans/bootstrap.swf</title>
  <script async src="https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js?client=ca-pub-3650100964443150" crossorigin="anonymous"></script></head>
  <body style="margin:0;padding:0;">
    <iframe src="/src/media1.clubpenguin.com/play/v2/games/beans/bootstrap.swf" title="/src/media1.clubpenguin.com/play/v2/games/beans/bootstrap.swf" frameborder="0" style="position:absolute;height:100%;width:100%;border:0;"  height="100%" width="100%"></iframe>
  </body>
</html>

https://icerink.solero.me/src/media1.clubpenguin.com/play/v2/games/beans/bootstrap.swf is the real SWF URL. The extension player page can't load that because it requests resources that respond with 403 Forbidden, however. But at the very least it does not panic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants