refactor(ProjectDatabase): rename Save-ProjectDatabase to Save-ProjectDatabaseSafe for clarity and safety

Author: rulasg

Notes.md

@@ -2,7 +2,7 @@
 
 Notes used during the development of the module
 
-## Save-ProjectDatabase
+## Save-ProjectDatabaseSafe
 
 ```mermaid
 graph TD;
@@ -11,7 +11,7 @@ graph TD;
 
     subgraph Module
         0([Sync-ProjectItemStaged])
-        1[Save-ProjectDatabase]
+        1[Save-ProjectDatabaseSafe]
         2[Get-Project]
         3[Get-Project]
         4[Set-ProjectV2Item]

Test/public/projectDatabase/project_database.test..ps1

@@ -22,7 +22,7 @@ function Test_SaveProjectDatabase_SafeId_Flag_PrivateCall{
 
         # Update project and the safeId should be updated
         $oldSafeId = $prj.safeId
-        Save-ProjectDatabase -Database $prj
+        Save-ProjectDatabaseSafe -Database $prj
         $prj2 = Get-ProjectFromDatabase -Owner $Owner -ProjectNumber $ProjectNumber
 
         Assert-IsNotNull -Object $prj2.safeId
@@ -50,7 +50,7 @@ function Test_SaveProjectDatabase_Safe_PrivateCall{
         $prj1 = Get-Project -Owner $Owner -ProjectNumber $ProjectNumber
 
         # modify the project
-        $db = Get-Project -Owner $Owner -ProjectNumber $ProjectNumber ; Save-ProjectDatabase -Database $db
+        $db = Get-Project -Owner $Owner -ProjectNumber $ProjectNumber ; Save-ProjectDatabaseSafe -Database $db
 
         # Check that safeId has changed
         $prj2 = Get-Project -Owner $Owner -ProjectNumber $ProjectNumber
@@ -59,7 +59,7 @@ function Test_SaveProjectDatabase_Safe_PrivateCall{
         ## When saving again as prj1 that has been saved before it will throw
         $hasThrow = $false
         try{
-            Save-ProjectDatabase -Database $prj1 -Safe
+            Save-ProjectDatabaseSafe -Database $prj1
         } catch {
             $hasThrow = $true
         }

private/projectDatabase/project_database.ps1

@@ -99,6 +99,14 @@ function Save-ProjectV2toDatabase{
     Save-ProjectDatabase -Database $db
 }
 
+function Save-ProjectDatabaseSafe{
+    [CmdletBinding()]
+    param(
+        [Parameter(Mandatory,Position = 0)][hashtable]$Database
+    )
+    Save-ProjectDatabase -Database $Database -Safe
+}
+
 function Save-ProjectDatabase{
     [CmdletBinding()]
     param(

private/projectDatabase/project_database_Async.ps1

@@ -22,7 +22,7 @@ function Sync-ProjectDatabaseAsync {
     $db = Sync-ProjectAsync -Database $db -SyncBatchSize $SyncBatchSize
 
     # Saved changes to database
-    Save-ProjectDatabase -Database $db -Safe
+    Save-ProjectDatabaseSafe -Database $db
 
     if (Test-ProjectDatabaseStaged -Owner $Owner -ProjectNumber $ProjectNumber) {
         "Still pending staged values" | Write-MyError

private/projectDatabase/project_database_Sync.ps1

@@ -20,7 +20,7 @@ function Sync-ProjectDatabase{
     # Send update to project
     $db = Sync-Project -Database $db
 
-    Save-ProjectDatabase -Database $db -Safe
+    Save-ProjectDatabaseSafe -Database $db
 
     if (Test-ProjectDatabaseStaged -Owner $Owner -ProjectNumber $ProjectNumber) {
         "Still pending staged values" | Write-MyError

public/project_item.ps1

@@ -42,7 +42,7 @@ function Get-ProjectItem {
     end {
         if ($dirty) {
             "Saving dirty database" | Write-Verbose
-            Save-ProjectDatabase -Database $db -Safe
+            Save-ProjectDatabaseSafe -Database $db
         }
     }
 
@@ -62,7 +62,7 @@ function Get-ProjectItem {
 #
 #     Set-Item $db $item
 #
-#     Save-ProjectDatabase -Database $db -Safe
+#     Save-ProjectDatabaseSafe -Database $db
 # }
 
 function Remove-ProjectItem {
@@ -85,7 +85,7 @@ function Remove-ProjectItem {
     }
 
     end {
-        Save-ProjectDatabase -Database $db -Safe
+        Save-ProjectDatabaseSafe -Database $db
     }
 
 }
@@ -255,7 +255,7 @@ function Edit-ProjectItem {
     Save-ItemFieldValue $db $itemId $FieldName $Value
 
     # Commit changes to the database
-    Save-ProjectDatabase -Database $db -Safe
+    Save-ProjectDatabaseSafe -Database $db
 
 } Export-ModuleMember -Function Edit-ProjectItem
 
@@ -310,7 +310,7 @@ function Add-ProjectItemDirect {
 
                 Set-Item $db $item
 
-                Save-ProjectDatabase -Database $db -Safe
+                Save-ProjectDatabaseSafe -Database $db
 
             }
 
@@ -374,7 +374,7 @@ function Remove-ProjectItemDirect {
         # Remove item from cache
         "Removing item [$ItemId] from cache" | Write-Verbose
         Remove-Item $db $ItemId
-        Save-ProjectDatabase -Database $db -Safe
+        Save-ProjectDatabaseSafe -Database $db
 
         return $ret
     }

public/project_item_staged.ps1

@@ -108,7 +108,7 @@ function Reset-ProjectItemStaged{
 
     $db.Staged = $null
 
-    Save-ProjectDatabase -Database $db -Safe
+    Save-ProjectDatabaseSafe -Database $db
 
 } Export-ModuleMember -Function Reset-ProjectItemStaged