Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can Hash implementation be improved? #2

Open
jplatte opened this issue Jun 16, 2019 · 1 comment
Open

Can Hash implementation be improved? #2

jplatte opened this issue Jun 16, 2019 · 1 comment
Labels
experimentation Something to experiment with

Comments

@jplatte
Copy link
Member

jplatte commented Jun 16, 2019

Title should be self-explanatory.

@jplatte
Copy link
Member Author

jplatte commented Jun 19, 2019

I had a look at the hashing interface, which I had never done before. We theoretically have 54 bits of information in Int and 53 bits in UInt. Both could be encoded in 7 bytes to give to the hasher instead of using the u64 value we currently use. After having thought about it, this only makes sense to me if we store our types in 7-byte form as well though. I personally don't see a large benefit in the saved byte per stored Int / UInt, but it would be a fun project. I'll create a new issue for it.

@jplatte jplatte added the experimentation Something to experiment with label Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimentation Something to experiment with
Development

No branches or pull requests

1 participant