Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: FunctionCallingProgram - pass tool_choice through to LLM (or remove the parameter) #17962

Open
GICodeWarrior opened this issue Feb 28, 2025 · 1 comment
Open

[Feature Request]: FunctionCallingProgram - pass tool_choice through to LLM (or remove the parameter) #17962

GICodeWarrior opened this issue Feb 28, 2025 · 1 comment
Labels
enhancement New feature or request triage Issue needs to be triaged/prioritized

Comments

@GICodeWarrior
Copy link
Contributor

Feature Description

FunctionCallingProgram accepts a tool_choice option that it does not use.

Workaround:
Pass tool_choice via llm_kwargs in call/acall.

Reason

It can be confusing to pass in an explicitly accepted parameter and have it not be used.

Value of Feature

No response
@GICodeWarrior GICodeWarrior added enhancement New feature or request triage Issue needs to be triaged/prioritized labels Feb 28, 2025
@logan-markewich
Copy link
Collaborator

I welcome a PR! If not ill probably get to it tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request triage Issue needs to be triaged/prioritized
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GICodeWarrior @logan-markewich