From 5715f4e5109b085a5111709574d94c5d97e32af9 Mon Sep 17 00:00:00 2001
From: runar <git@runar.st>
Date: Sun, 23 Jan 2022 12:56:49 +0100
Subject: [PATCH] Change naming and coding conventions (#1)

* Add empty index.html files to all folders
* Add releases folder to gitignore
* Rename hook file to comply with naming conventions
* Add full name to LICENSE
* Make code comply with the PEAR standard
---
 .gitignore               |  1 +
 LICENSE                  |  2 +-
 dev/css/index.html       |  0
 dev/html/index.html      |  0
 dev/index.html           |  0
 dev/js/index.html        |  0
 dev/jslang.php           |  3 +--
 dev/lang.php             |  3 +--
 dev/resources/index.html |  0
 dev/setup/10000.php      | 25 ++++++++++++-------------
 dev/setup/index.html     |  0
 dev/setup/install.php    | 25 ++++++++++++-------------
 dev/versions.json        |  4 +++-
 hooks/File_Amazon.php    | 25 +++++++++++++++++++++++++
 hooks/ipsFileAmazon.php  | 25 -------------------------
 15 files changed, 56 insertions(+), 57 deletions(-)
 create mode 100644 dev/css/index.html
 create mode 100644 dev/html/index.html
 create mode 100644 dev/index.html
 create mode 100644 dev/js/index.html
 create mode 100644 dev/resources/index.html
 create mode 100644 dev/setup/index.html
 create mode 100644 hooks/File_Amazon.php
 delete mode 100644 hooks/ipsFileAmazon.php

diff --git a/.gitignore b/.gitignore
index 4fec19c..fd4ac79 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1 +1,2 @@
 .lvimrc
+/releases
diff --git a/LICENSE b/LICENSE
index c12bcef..b6b9189 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2019 runar
+Copyright (c) 2019 Runar Skaare Tveiten
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
diff --git a/dev/css/index.html b/dev/css/index.html
new file mode 100644
index 0000000..e69de29
diff --git a/dev/html/index.html b/dev/html/index.html
new file mode 100644
index 0000000..e69de29
diff --git a/dev/index.html b/dev/index.html
new file mode 100644
index 0000000..e69de29
diff --git a/dev/js/index.html b/dev/js/index.html
new file mode 100644
index 0000000..e69de29
diff --git a/dev/jslang.php b/dev/jslang.php
index 8033b2e..890904e 100644
--- a/dev/jslang.php
+++ b/dev/jslang.php
@@ -1,4 +1,3 @@
 <?php
 
-$lang = array(
-);
+$lang = array();
diff --git a/dev/lang.php b/dev/lang.php
index 8033b2e..890904e 100644
--- a/dev/lang.php
+++ b/dev/lang.php
@@ -1,4 +1,3 @@
 <?php
 
-$lang = array(
-);
+$lang = array();
diff --git a/dev/resources/index.html b/dev/resources/index.html
new file mode 100644
index 0000000..e69de29
diff --git a/dev/setup/10000.php b/dev/setup/10000.php
index 5068f94..dfeea3d 100644
--- a/dev/setup/10000.php
+++ b/dev/setup/10000.php
@@ -1,10 +1,9 @@
 //<?php
 
 /* To prevent PHP errors (extending class does not exist) revealing path */
-if ( !\defined( '\IPS\SUITE_UNIQUE_KEY' ) )
-{
-	header( ( isset( $_SERVER['SERVER_PROTOCOL'] ) ? $_SERVER['SERVER_PROTOCOL'] : 'HTTP/1.0' ) . ' 403 Forbidden' );
-	exit;
+if (!\defined('\IPS\SUITE_UNIQUE_KEY')) {
+    header((isset($_SERVER['SERVER_PROTOCOL']) ? $_SERVER['SERVER_PROTOCOL'] : 'HTTP/1.0') . ' 403 Forbidden');
+    exit;
 }
 
 /**
@@ -12,13 +11,13 @@
  */
 class ips_plugins_setup_upg_10000
 {
-	/**
-	 * Step 1
-	 *
-	 * @return true
-	 */
-	public function step1()
-	{
-		return true;
-	}
+    /**
+     * Step 1
+     *
+     * @return true
+     */
+    public function step1()
+    {
+        return true;
+    }
 }
diff --git a/dev/setup/index.html b/dev/setup/index.html
new file mode 100644
index 0000000..e69de29
diff --git a/dev/setup/install.php b/dev/setup/install.php
index fd4056c..2698087 100644
--- a/dev/setup/install.php
+++ b/dev/setup/install.php
@@ -1,10 +1,9 @@
 //<?php
 
 /* To prevent PHP errors (extending class does not exist) revealing path */
-if ( !\defined( '\IPS\SUITE_UNIQUE_KEY' ) )
-{
-	header( ( isset( $_SERVER['SERVER_PROTOCOL'] ) ? $_SERVER['SERVER_PROTOCOL'] : 'HTTP/1.0' ) . ' 403 Forbidden' );
-	exit;
+if (!\defined('\IPS\SUITE_UNIQUE_KEY')) {
+    header((isset($_SERVER['SERVER_PROTOCOL']) ? $_SERVER['SERVER_PROTOCOL'] : 'HTTP/1.0') . ' 403 Forbidden');
+    exit;
 }
 
 /**
@@ -12,13 +11,13 @@
  */
 class ips_plugins_setup_install
 {
-	/**
-	 * Step 1
-	 *
-	 * @return true
-	 */
-	public function step1()
-	{
-		return true;
-	}
+    /**
+     * Step 1
+     *
+     * @return true
+     */
+    public function step1()
+    {
+        return true;
+    }
 }
diff --git a/dev/versions.json b/dev/versions.json
index 4dd0783..f76d538 100644
--- a/dev/versions.json
+++ b/dev/versions.json
@@ -1 +1,3 @@
-{"10000":"1.0.0"}
\ No newline at end of file
+{
+  "10000": "1.0.0"
+}
diff --git a/hooks/File_Amazon.php b/hooks/File_Amazon.php
new file mode 100644
index 0000000..129b606
--- /dev/null
+++ b/hooks/File_Amazon.php
@@ -0,0 +1,25 @@
+//<?php
+
+/* To prevent PHP errors (extending class does not exist) revealing path */
+if (!\defined('\IPS\SUITE_UNIQUE_KEY')) {
+    exit;
+}
+
+class hook77 extends _HOOK_CLASS_
+{
+    /**
+     * Display name
+     *
+     * @param array $settings the array with bucket settings
+     *
+     * @return string
+     */
+    public static function displayName($settings)
+    {
+        if (!empty($settings['bucket_path'])) {
+            $settings['bucket'] .= "/${settings['bucket_path']}";
+        }
+
+        return parent::displayName($settings);
+    }
+}
diff --git a/hooks/ipsFileAmazon.php b/hooks/ipsFileAmazon.php
deleted file mode 100644
index e7a3b11..0000000
--- a/hooks/ipsFileAmazon.php
+++ /dev/null
@@ -1,25 +0,0 @@
-//<?php
-
-/* To prevent PHP errors (extending class does not exist) revealing path */
-if ( !\defined( '\IPS\SUITE_UNIQUE_KEY' ) )
-{
-	exit;
-}
-
-class hook77 extends _HOOK_CLASS_
-{
-	/**
-	* Display name
-	*
-	* @param array $settings Configuration settings
-	* @return string
-	*/
-	public static function displayName( $settings )
-	{
-		if ( ! empty( $settings['bucket_path'] ) )
-		{
-			$settings['bucket'] .= "/${settings['bucket_path']}";
-		}
-		return parent::displayName( $settings );
-	}
-}