Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests to work with or without local registry setup #142

Open
pendo324 opened this issue Mar 27, 2024 · 0 comments
Open

Refactor tests to work with or without local registry setup #142

pendo324 opened this issue Mar 27, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@pendo324
Copy link
Member

Right now, all of the tests are written to use the localImages map which is only populated if the SetupLocalRegistry function is first called.

The code should be refactored such that the tests don't care about such details and work regardless of whether the images are local or not (maybe through a helper struct with a GetImage(localImage) method).

See here for an example error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant