refactor(types): add Fee error variant to DecodePsbtError

Add Fee(ParseAmountError) variant to handle fee conversion failures.

This prepares for the upcoming change from u64 to f64 for the fee field.

Affected versions: v17, v23, v24, v30

Author: deadmanoz

types/src/v17/raw_transactions/error.rs

@@ -24,6 +24,8 @@ pub enum DecodePsbtError {
     Inputs(PsbtInputError),
     /// Conversion of one of the PSBT outputs failed.
     Outputs(PsbtOutputError),
+    /// Conversion of the `fee` field failed.
+    Fee(ParseAmountError),
 }
 
 impl fmt::Display for DecodePsbtError {
@@ -35,6 +37,7 @@ impl fmt::Display for DecodePsbtError {
             Self::Inputs(ref e) => write_err!(f, "conversion of one of the PSBT inputs failed"; e),
             Self::Outputs(ref e) =>
                 write_err!(f, "conversion of one of the PSBT outputs failed"; e),
+            Self::Fee(ref e) => write_err!(f, "conversion of the `fee` field failed"; e),
         }
     }
 }
@@ -47,6 +50,7 @@ impl std::error::Error for DecodePsbtError {
             Self::Unknown(ref e) => Some(e),
             Self::Inputs(ref e) => Some(e),
             Self::Outputs(ref e) => Some(e),
+            Self::Fee(ref e) => Some(e),
         }
     }
 }

types/src/v23/raw_transactions/error.rs

@@ -2,6 +2,7 @@
 
 use core::fmt;
 
+use bitcoin::amount::ParseAmountError;
 use bitcoin::{address, bip32, hex, sighash};
 
 use super::{Bip32DerivError, PartialSignatureError, RawTransactionError, WitnessUtxoError};
@@ -22,6 +23,8 @@ pub enum DecodePsbtError {
     Inputs(PsbtInputError),
     /// Conversion of one of the PSBT outputs failed.
     Outputs(PsbtOutputError),
+    /// Conversion of the `fee` field failed.
+    Fee(ParseAmountError),
 }
 
 impl fmt::Display for DecodePsbtError {
@@ -37,6 +40,7 @@ impl fmt::Display for DecodePsbtError {
             Self::Inputs(ref e) => write_err!(f, "conversion of one of the PSBT inputs failed"; e),
             Self::Outputs(ref e) =>
                 write_err!(f, "conversion of one of the PSBT outputs failed"; e),
+            Self::Fee(ref e) => write_err!(f, "conversion of the `fee` field failed"; e),
         }
     }
 }
@@ -51,6 +55,7 @@ impl std::error::Error for DecodePsbtError {
             Self::Unknown(ref e) => Some(e),
             Self::Inputs(ref e) => Some(e),
             Self::Outputs(ref e) => Some(e),
+            Self::Fee(ref e) => Some(e),
         }
     }
 }

types/src/v24/raw_transactions/error.rs

@@ -2,6 +2,7 @@
 
 use core::fmt;
 
+use bitcoin::amount::ParseAmountError;
 use bitcoin::taproot::{IncompleteBuilderError, TaprootBuilderError, TaprootError};
 use bitcoin::{bip32, hex, secp256k1, sighash};
 
@@ -23,6 +24,8 @@ pub enum DecodePsbtError {
     Inputs(PsbtInputError),
     /// Conversion of one of the PSBT outputs failed.
     Outputs(PsbtOutputError),
+    /// Conversion of the `fee` field failed.
+    Fee(ParseAmountError),
 }
 
 impl fmt::Display for DecodePsbtError {
@@ -38,6 +41,7 @@ impl fmt::Display for DecodePsbtError {
             Self::Inputs(ref e) => write_err!(f, "conversion of one of the PSBT inputs failed"; e),
             Self::Outputs(ref e) =>
                 write_err!(f, "conversion of one of the PSBT outputs failed"; e),
+            Self::Fee(ref e) => write_err!(f, "conversion of the `fee` field failed"; e),
         }
     }
 }
@@ -52,6 +56,7 @@ impl std::error::Error for DecodePsbtError {
             Self::Unknown(ref e) => Some(e),
             Self::Inputs(ref e) => Some(e),
             Self::Outputs(ref e) => Some(e),
+            Self::Fee(ref e) => Some(e),
         }
     }
 }

types/src/v30/raw_transactions/error.rs

@@ -2,6 +2,7 @@
 
 use core::fmt;
 
+use bitcoin::amount::ParseAmountError;
 use bitcoin::taproot::{IncompleteBuilderError, TaprootBuilderError, TaprootError};
 use bitcoin::{bip32, hex, secp256k1, sighash};
 
@@ -23,6 +24,8 @@ pub enum DecodePsbtError {
     Inputs(PsbtInputError),
     /// Conversion of one of the PSBT outputs failed.
     Outputs(PsbtOutputError),
+    /// Conversion of the `fee` field failed.
+    Fee(ParseAmountError),
 }
 
 impl fmt::Display for DecodePsbtError {
@@ -38,6 +41,7 @@ impl fmt::Display for DecodePsbtError {
             Self::Inputs(ref e) => write_err!(f, "conversion of one of the PSBT inputs failed"; e),
             Self::Outputs(ref e) =>
                 write_err!(f, "conversion of one of the PSBT outputs failed"; e),
+            Self::Fee(ref e) => write_err!(f, "conversion of the `fee` field failed"; e),
         }
     }
 }
@@ -52,6 +56,7 @@ impl std::error::Error for DecodePsbtError {
             Self::Unknown(ref e) => Some(e),
             Self::Inputs(ref e) => Some(e),
             Self::Outputs(ref e) => Some(e),
+            Self::Fee(ref e) => Some(e),
         }
     }
 }