Skip to content

Commit 1ca2e1b

Browse files
committed
Enable bitcoin_hashes v0.14.0
Hardware devices like the smallest binary possible, currently if one builds with latest `rust-bitcoin` and `rust-bip39` they get two versions of `bitcoin_hashes` in the dependency graph because we don't support the latest `bitcoin_hashes`. We use a range dependency for `bitcoin_hashes`. We can support the latest version with no code changes. However using the latest version causes the MSRV to increase. Add the latest version of `bitcoin_hashes` to the range dependency.
1 parent 5bb4711 commit 1ca2e1b

File tree

2 files changed

+7
-14
lines changed

2 files changed

+7
-14
lines changed

Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,13 @@ serde = { version = "1.0", default-features = false, features = [ "alloc" ], opt
4949
zeroize = { version = "1.5", features = ["zeroize_derive"], optional = true }
5050

5151
# Unexported dependnecies
52-
bitcoin_hashes = { version = ">=0.12, <=0.13", default-features = false }
52+
bitcoin_hashes = { version = "<0.15", default-features = false }
5353
unicode-normalization = { version = "0.1.22", default-features = false, optional = true }
5454

5555
[dev-dependencies]
5656
# Enabling the "rand" feature by default to run the benches
5757
bip39 = { path = ".", features = ["rand"] }
58-
bitcoin_hashes = ">=0.12,<0.14" # enable default features for test
58+
bitcoin_hashes = ">=0.12,<0.15" # enable default features for test
5959

6060

6161
[package.metadata.docs.rs]

README.md

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -31,19 +31,12 @@ Use the `all-languages` feature to enable all languages.
3131

3232
This crate supports Rust v1.41.1 and up and works with `no_std`.
3333

34-
The `bitcoin_hashes` range dependency effects the MSRV as follows
34+
Using `bitcoin_hashes v0.14.0` raises the MSRV to `1.56.1`.
3535

36-
- `bitcoin_hashes v0.12`: MSRV v1.41.1
37-
- `bitcoin_hashes v0.13`: MSRV v1.48.0
38-
39-
When using older version of Rust, you might have to pin the versions of several crates, for an up-to-date list refer to [`contrib/test.sh`](contrib/test.sh):
40-
41-
```bash
42-
cargo update --package "bitcoin_hashes" --precise "0.12.0"
43-
cargo update --package "rand" --precise "0.6.0"
44-
cargo update --package "libc" --precise "0.2.151"
45-
cargo update --package "tinyvec" --precise "1.6.0"
46-
cargo update --package "unicode-normalization" --precise "0.1.22"
36+
When using older version of Rust, you might have to pin the version of the
37+
`bitcoin_hashes` crate used as such:
38+
```
39+
$ cargo update --package "bitcoin_hashes" --precise "0.12.0"
4740
```
4841

4942
If you enable the `zeroize` feature the MSRV becomes 1.51.

0 commit comments

Comments
 (0)