Skip to content

Commit ecb93c3

Browse files
committed
Filter out unsupported -Wl,--dynamicbase link arg for Windows gnu targets
xref #96
1 parent a3acd60 commit ecb93c3

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/zig.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,13 @@ impl Zig {
102102
} else if arg == "-lwindows" || arg == "-l:libpthread.a" || arg == "-lgcc" {
103103
return None;
104104
} else if arg == "-Wl,--disable-auto-image-base"
105+
|| arg == "-Wl,--dynamicbase"
105106
|| arg == "-Wl,--large-address-aware"
106107
{
107108
// https://github.com/rust-lang/rust/blob/f0bc76ac41a0a832c9ee621e31aaf1f515d3d6a5/compiler/rustc_target/src/spec/windows_gnu_base.rs#L23
109+
// https://github.com/rust-lang/rust/blob/2fb0e8d162a021f8a795fb603f5d8c0017855160/compiler/rustc_target/src/spec/windows_gnu_base.rs#L22
108110
// https://github.com/rust-lang/rust/blob/f0bc76ac41a0a832c9ee621e31aaf1f515d3d6a5/compiler/rustc_target/src/spec/i686_pc_windows_gnu.rs#L16
109-
// zig doesn't support --disable-auto-image-base, --large-address-aware
111+
// zig doesn't support --disable-auto-image-base, --dynamicbase, and --large-address-aware
110112
return None;
111113
}
112114
} else if arg == "-Wl,--no-undefined-version" {

0 commit comments

Comments
 (0)