Skip to content

Commit 6513773

Browse files
docs: document that pmbr shouldn't be used unless nedded (#136)
While testing a new build of our image, we found that it didn't boot in UEFI mode on a Lenovo M700 and tracked it down to this. I think it makes sense to call out this caveat in the rustdoc.
1 parent 4826758 commit 6513773

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/lib.rs

+4
Original file line numberDiff line numberDiff line change
@@ -1246,6 +1246,10 @@ impl GPT {
12461246
/// MBR partition table is marked as bootable. Some legacy BIOS systems do not consider a disk
12471247
/// to be bootable if there isn't an MBR partition marked as bootable in the MBR partition
12481248
/// table.
1249+
///
1250+
/// <div class="warning">Some systems will not consider a disk to be bootable in UEFI mode
1251+
/// if the pMBR is marked as bootable, so this should only be used if booting on legacy BIOS
1252+
/// systems is a requirement.</div>
12491253
pub fn write_bootable_protective_mbr_into<W: ?Sized>(
12501254
mut writer: &mut W,
12511255
sector_size: u64,

0 commit comments

Comments
 (0)