Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constant assertions #403

Closed
wants to merge 1 commit into from
Closed

Fix constant assertions #403

wants to merge 1 commit into from

Conversation

newAM
Copy link
Member

@newAM newAM commented Nov 1, 2023 •
edited
Loading

Fixes #351
Closes #404 (this is a superset)

I still need to check that this doesn't have a runtime cost.

@newAM newAM marked this pull request as draft November 1, 2023 00:34
@newAM newAM force-pushed the const-assert branch 2 times, most recently from 0b88c6c to 593b92a Compare November 1, 2023 00:35
@newAM newAM mentioned this pull request Nov 1, 2023
Open
@newAM
Copy link
Member Author

newAM commented Nov 1, 2023

I tested this out on a thumbv7em-none-eabihf target, with and without the new assertions, the resulting binary size was the same. No runtime cost that I can see.

@newAM newAM marked this pull request as ready for review November 1, 2023 04:33
@newAM
Copy link
Member Author

newAM commented Nov 1, 2023

...I misread #351, I thought something was asserting at runtime. This doesn't improve the compatibility with cargo check, going to close for now.

@newAM newAM closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Const assertions are not guaranteed to cause compile failures
1 participant
@newAM