Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Borrow for Vec and String #478

Closed
Icelk opened this issue Jun 20, 2024 · 2 comments · Fixed by #499
Closed

Implement Borrow for Vec and String #478

Icelk opened this issue Jun 20, 2024 · 2 comments · Fixed by #499
Labels
enhancement

Comments

@Icelk
Copy link
Contributor

Icelk commented Jun 20, 2024

This would enable using String as a key in one of the map or set types in this crate. I see no reason as to why that would not be technically possible.

If you want, I can write a PR.
@Dirbaio
Copy link
Member

Dirbaio commented Jul 1, 2024

that'd be a nice addition, please send a PR!

@Icelk Icelk mentioned this issue Jul 2, 2024
Merged
@Icelk
Copy link
Contributor Author

Icelk commented Jul 2, 2024

PR in #499 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Impl Borrow and BorrowMut for String and Vec. Icelk/heapless
3 participants
@Dirbaio @newAM @Icelk