Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax indexmap PartialEq bounds so value doesn't need to be Eq #503

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Relax indexmap PartialEq bounds so value doesn't need to be Eq #503

wants to merge 6 commits into from

Conversation

YuhanLiin
Copy link
Contributor

The old bounds were unnecessarily strict. This PR relaxes the V: Eq bound to V: PartialEq.

@reitermarkus
Copy link
Member

Can you add a test for something that didn't work before?

reitermarkus
reitermarkus reviewed Jul 22, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reitermarkus reitermarkus reitermarkus left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuhanLiin @reitermarkus