Skip to content
This repository was archived by the owner on Nov 20, 2023. It is now read-only.
This repository was archived by the owner on Nov 20, 2023. It is now read-only.

EnrError should implement std::error::Error #37

@adoerr

Description

@adoerr

EnrError currently is a plain struct.

IMO, this is a bit non-idiomatic. Especially conversion into other custom error types is more involved than it should be. For example, thiserror offers a #[from] attribute which auto-generates a From implementation. This, however, expects the source error type to implement std::error::Error.

As an alternative, we could just derive thiserror::Error which will generate a std::error::Error implementation.

WDYT?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions