You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is easy to test, but is it really necessary? The following situation would rarely occur even if we add public non-Send types in the future, I think.
use std::thread;let x = TypeThatHasRc::new();
thread::Builder::new().name("with-large-stack".into()).stack_size(32*1024*1024).spawn(move || {let _ = x;}).unwrap().join().unwrap();
Relating to #18.
https://rust-lang.github.io/api-guidelines/checklist.html
as_
,to_
,into_
conventions (C-CONV)iter
,iter_mut
,into_iter
(C-ITER)Copy
,Clone
,Eq
,PartialEq
,Ord
,PartialOrd
,Hash
,Debug
,Display
,Default
From
,AsRef
,AsMut
(C-CONV-TRAITS)FromIterator
andExtend
(C-COLLECT)Serialize
,Deserialize
(C-SERDE)Send
andSync
where possible (C-SEND-SYNC)Hex
,Octal
,Binary
formatting (C-NUM-FMT)R: Read
andW: Write
by value (C-RW-VALUE)?
, nottry!
, notunwrap
(C-QUESTION-MARK)readme, keywords, categories
Deref
andDerefMut
(C-DEREF)bool
orOption
(C-CUSTOM-TYPE)bitflags
, not enums (C-BITFLAG)Debug
(C-DEBUG)Debug
representation is never empty (C-DEBUG-NONEMPTY)C-CASE
Should we rename
Segtree
toSegTree
?C-COMMON-TRAITS, C-DEBUG
Most of the traits can be just
#[derive]
d.C-COLLECT
Maybe
Segtree
andLazySegtree
should implementFromIterator
.C-SEND-SYNC
It is easy to test, but is it really necessary? The following situation would rarely occur even if we add public non-
Send
types in the future, I think.C-NUM-FMT
Should
ModInt
s implement them...?C-EXAMPLE
Examples will help users, especially Rust beginners.
C-FAILURE
We should add
"# Panics"
sections.C-PERMISSIVE
Maybe we should add
"# License"
section the the README.The text was updated successfully, but these errors were encountered: